domoticz: fix build and add test.sh#29288
Open
commodo wants to merge 3 commits intoopenwrt:masterfrom
Open
Conversation
commodo
force-pushed
the
fix-domoticz-boost-asio
branch
from
b819959 to
06134bc
Compare
Member
|
Generic tests are now forced for all packages, irrespective of |
Contributor
Author
Two failures stand-out. |
boost::asio::post() without an explicit executor fails to compile with Boost >= 1.82 due to changes in the executor model: bare lambdas no longer have an implicit system executor that satisfies the blocking.never requirement. Pass io_context_ explicitly as the first argument so the handler is dispatched on the correct io_context thread, which is the original intent of the call (making stop() safe to call from any thread). Add test.sh domoticz is a daemon requiring a database and network port; it does not implement a --version flag. Verify the binary is present and executable. Disable LTO to fix link failure on i386 with musl fortify Suggested via openwrt#29239 Also tested. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
MinOZW does not implement any --version flag, so skip the generic version check. Just verify the binary is present and executable. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
libquadmath is only packaged for x86 and powerpc targets in OpenWrt. Declaring it as an unconditional runtime dependency of boost-charconv causes apk installation failure on all other architectures (e.g. i386, arm, mips) with "libquadmath (no such package)". Guard the dependency with an ARCH filter so it is only pulled in on platforms where the package actually exists. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro> boost: add x86 to libquadmath arch conditional in boost-charconv libquadmath is available on x86 (i386) in addition to x86_64 and powerpc variants. Include it in the filter so boost-charconv gets the correct dependency on 32-bit x86 targets. Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
commodo
force-pushed
the
fix-domoticz-boost-asio
branch
from
06134bc to
1b2883c
Compare
Member
|
Also for some reason |
Member
|
liblzma is purging file: I guess |
GeorgeSapkin
force-pushed
the
fix-domoticz-boost-asio
branch
from
1b2883c to
3f1d898
Compare
This comment was marked as resolved.
This comment was marked as resolved.
GeorgeSapkin
force-pushed
the
fix-domoticz-boost-asio
branch
from
3f1d898 to
1b2883c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @dwmw2
Description:
boost::asio::post() without an explicit executor fails to compile with Boost >= 1.82 due to changes in the executor model: bare lambdas no longer have an implicit system executor that satisfies the blocking.never requirement.
Pass io_context_ explicitly as the first argument so the handler is dispatched on the correct io_context thread, which is the original intent of the call (making stop() safe to call from any thread).
Add test.sh
domoticz is a daemon requiring a database and network port; it does not implement a --version flag. Verify the binary is present and executable.
Disable LTO to fix link failure on i386 with musl fortify Suggested via #29239 Also tested.
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.