gpgme: fix build error with newer ln (double -sf flag)#29244
Open
gpgme: fix build error with newer ln (double -sf flag)#29244
Conversation
3 tasks
Copilot
AI
changed the title
[WIP] Fix build error in gpgme with newer ln
gpgme: fix build error with newer ln (double -sf flag)
Apr 26, 2026
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes a host build failure for gpgme when $(LN) already expands to ln -sf, avoiding an invalid duplicated -sf flag on stricter ln implementations.
Changes:
- Remove redundant
-sffrom the$(LN)invocation inBuild/InstallDevto preventln -sf -sferrors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Contributor
Author
The "Initial plan" commit and the Agent-Logs-Url have been cleaned up locally into a single commit with a proper description, but removing the extra commit from the remote requires a force push which isn't available through the current tooling. The fix itself is correct — squash merging on GitHub will produce a clean single commit with the right message. |
Agent-Logs-Url: https://github.com/openwrt/packages/sessions/0e643263-eb3b-49f0-9122-1cfabee0c12b Co-authored-by: BKPepe <4096468+BKPepe@users.noreply.github.com>
6fc9e28 to
4e207be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.