Allow multi node jobs#5
Draft
shapovalovts wants to merge 17 commits into
Draft
Conversation
Harden Azure home mount bootstrap checks Implement Azure explicit customData wiring Refine Azure customData injection Align Azure tests with explicit customData Tighten Azure bootstrap error handling Clarify Azure compute VM dependencies Finalize Azure customData validation Rename Azure private IP variable Harden Azure customData test selection Extract Azure network API version constant
There was a problem hiding this comment.
Pull request overview
Adds Azure multi-node partition support by introducing a validated VM count parameter, generating additional compute VMs from the ARM template, and updating cloud-init to configure shared /home via NFS across nodes.
Changes:
- Replace the single-VM Azure deployment behavior with template cloning to add compute NIC/VM/extension resources when
count > 1. - Update Azure cloud-init and ARM template parameters to support multi-node bootstrapping (NFS packages, main/compute placeholders, secure storage key injection).
- Modernize async tests away from
asynctestand add new unit tests covering VM count parsing, template expansion, and customData placeholder replacement.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/test_openstack.py | Switch async test base class from asynctest to unittest.IsolatedAsyncioTestCase. |
| test/test_azure.py | Switch async test base class; update count behavior and add invalid-count test. |
| test/test_azure_custom_data.py | New tests validating customData placeholder injection and shell quoting. |
| test/test_azure_connector.py | New unit tests for VM count parsing, multi-node ARM template cloning, and rollback behavior. |
| swmcloudgate/routers/azure/templates/partition.json | Add storageKey secure parameter, restrict admin username, fix authorized_keys path, and require explicit vmNameMain. |
| swmcloudgate/routers/azure/templates/cloud-init.yaml | Install NFS packages required for shared home in multi-node deployments. |
| swmcloudgate/routers/azure/templates/cloud-init.sh | Add NFS server/client setup, placeholder-driven VM context, and safer shell quoting for credentials. |
| swmcloudgate/routers/azure/partitions.py | Rename log field and convert VM count validation failures into 400 Bad Request. |
| swmcloudgate/routers/azure/connector.py | Add VM count parsing, multi-node resource cloning, ARM customData placeholder replacement, and deployment rollback on failure. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…re/multi-node-jobs
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.