refactor: make sha3 exterior interface unmodified in patch#9
Open
gdmlcjs wants to merge 4 commits intoopenvm/sha3-v0.10.8from
Open
refactor: make sha3 exterior interface unmodified in patch#9gdmlcjs wants to merge 4 commits intoopenvm/sha3-v0.10.8from
gdmlcjs wants to merge 4 commits intoopenvm/sha3-v0.10.8from
Conversation
gdmlcjs
force-pushed
the
chore/sha3-v0.10.8-patch
branch
from
e10bc81 to
f8daa2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the sha3 patch to use the lower level
openvm-keccak256-guestcrate instead of theopenvm-keccak256crate.The internal implementations are swapped to use the openvm functions for the zkvm target. The
native_keccakfandnative_xorinfunctions are used everywhere in all of the sha3 hashes (Sha3, Keccak, Shake, TurboShake, CShake) except for the 12-round permutation inTurboShake.The hashing structs and traits are now untouched so that the interface of the patched version is equivalent to the upstream version.