chore: use openvm guest library for zkvm target#4
Open
gdmlcjs wants to merge 1 commit intoopenvm/sha3-v0.11.0from
Open
chore: use openvm guest library for zkvm target#4gdmlcjs wants to merge 1 commit intoopenvm/sha3-v0.11.0from
gdmlcjs wants to merge 1 commit intoopenvm/sha3-v0.11.0from
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
gdmlcjs
force-pushed
the
chore/sha3-v0.11.0-patch
branch
from
06f0d77 to
f429d7d
Compare
gdmlcjs
force-pushed
the
chore/sha3-v0.11.0-patch
branch
from
f429d7d to
b602904
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a patch of the sha3-0.11.0 tag that uses OpenVM at branch develop-v2.0.0-rc.1.
The internal functions for all of the hashes in
sha3(Sha3, Keccak, Shake), when compiled for ZKVM, are implemented using the OpenVM guest libraryopenvm-keccak256-guest.A separate test directory is added to check that using the patched version gives the correct result and indeed calls the custom Keccak opcodes.
closes INT-7393