refactor: make sha2 exterior interface unmodified in patch#10
Open
gdmlcjs wants to merge 2 commits intoopenvm/sha2-v0.10.8from
Open
refactor: make sha2 exterior interface unmodified in patch#10gdmlcjs wants to merge 2 commits intoopenvm/sha2-v0.10.8from
gdmlcjs wants to merge 2 commits intoopenvm/sha2-v0.10.8from
Conversation
…e openvm guest library for zkvm target (#1)" Revert the wrapper-type zkvm patch (and its openvm-v2 bump) to restore the upstream sha2 v0.10.8 tree in preparation for the backend-level patch. This reverts commits 07c0c64d and 8e16631. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gdmlcjs
force-pushed
the
chore/sha2-v0.10.8-patch
branch
from
3024a68 to
7591ce9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the sha2 patch to use the lower level
openvm-sha2-guestcrate instead of theopenvm-sha2crate.The internal implementations are swapped to use the openvm functions for the zkvm target. The
zkvm_sha256_implandzkvm_sha512_implfunctions are used for all of the sha2 hashes.The hashing structs and traits are now untouched so that the interface of the patched version is equivalent to the upstream version.