Skip to content

update hf pull doc#4033

Open
dtrawins wants to merge 2 commits intomainfrom
hf-pull-fix
Open

update hf pull doc#4033
dtrawins wants to merge 2 commits intomainfrom
hf-pull-fix

Conversation

@dtrawins
Copy link
Collaborator

@dtrawins dtrawins commented Mar 2, 2026

🛠 Summary

add missing --user parameter in docker command

🧪 Checklist

  • Unit tests added.
  • The documentation updated.
  • Change follows security best practices.
    ``

Copilot AI review requested due to automatic review settings March 2, 2026 23:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates OVMS pull-mode documentation for using optimum-cli (Hugging Face model pull + conversion/quantization) via Docker examples.

Changes:

  • Fixes the Docker docker run invocation to correctly pass the user/group via -u.
  • Updates the Docker example snippet to create a local models directory and mount it via $(pwd)/models.

docker run $(id -u):$(id -g) --rm -v <model_repository_path>:/models:rw openvino/model_server:latest-py --pull --source_model "Qwen/Qwen3-8B" --model_repository_path /models --model_name Qwen3-8B --task text_generation --weight-format int8
```bash
mkdir -p models
docker run -u $(id -u):$(id -g) --rm -v $(pwd)/models:/models:rw openvino/model_server:latest-py --pull --source_model "Qwen/Qwen3-4B" --model_repository_path /models --model_name Qwen3-4B --task text_generation --weight-format int8
Copy link

Copilot AI Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Docker example under “Example for pulling Qwen/Qwen3-8B” pulls Qwen/Qwen3-4B and sets --model_name Qwen3-4B, which conflicts with the section title and the adjacent baremetal example that still uses Qwen/Qwen3-8B. Please make the example consistent (either update the example back to 8B or change the surrounding text and other commands to 4B).

Suggested change
docker run -u $(id -u):$(id -g) --rm -v $(pwd)/models:/models:rw openvino/model_server:latest-py --pull --source_model "Qwen/Qwen3-4B" --model_repository_path /models --model_name Qwen3-4B --task text_generation --weight-format int8
docker run -u $(id -u):$(id -g) --rm -v $(pwd)/models:/models:rw openvino/model_server:latest-py --pull --source_model "Qwen/Qwen3-8B" --model_repository_path /models --model_name Qwen3-8B --task text_generation --weight-format int8

Copilot uses AI. Check for mistakes.
@dtrawins dtrawins requested review from ngrozae and rasapala March 3, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants