Conversation
There was a problem hiding this comment.
Pull request overview
Updates demo UX by clarifying an export_model.py CLI option and adjusting the audio demo setup instructions.
Changes:
- Clarify the
--enable_prefix_cachingargument help text inexport_model.py. - Add a step in the audio demo README to download
create_speaker_embedding.pybefore running it.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
demos/common/export_models/export_model.py |
Updates CLI help text for --enable_prefix_caching to clarify default behavior. |
demos/audio/README.md |
Adds a curl command to fetch the speaker-embedding helper script before execution. |
| curl --output audio_samples/audio.wav "https://www.voiptroubleshooter.com/open_speech/american/OSR_us_000_0032_8k.wav" | ||
| mkdir -p models | ||
| mkdir -p models/speakers | ||
| curl https://raw.githubusercontent.com/openvinotoolkit/model_server/refs/heads/main/demos/audio/create_speaker_embedding.py -o create_speaker_embedding.py |
There was a problem hiding this comment.
The README now instructs users to download and execute create_speaker_embedding.py directly from the main branch URL. This reduces reproducibility (it may not match the stated OVMS version requirement in this doc) and is riskier from a supply-chain perspective since it runs code fetched at runtime. Consider either referencing the script directly from this repo checkout (e.g., python demos/audio/create_speaker_embedding.py ...) or pinning the download URL to a specific release tag/commit that matches the documented OVMS version (and ideally doing the same for the adjacent requirements.txt download in this block).
🛠 Summary
JIRA/Issue if applicable.
Describe the changes.
🧪 Checklist
``