[main] Fix params.md and cli parser cpp#4029
Merged
dkalinowski merged 4 commits intomainfrom Mar 3, 2026
Merged
Conversation
0425281 to
116fabd
Compare
przepeck
approved these changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates OVMS CLI help/docs around Hugging Face pull/export options and embeddings graph parameters, and removes a deprecated/unused CLI option.
Changes:
- Adjust embeddings graph CLI
--poolingoption description. - Remove
--resizeoption from the main CLI parser. - Update
docs/parameters.mdfor optimum-cli pull parameters and embeddings pooling documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/graph_export/embeddings_graph_cli_parser.cpp |
Updates --pooling CLI help text for embeddings graph export options. |
src/cli_parser.cpp |
Removes the --resize CLI option from single-model options. |
docs/parameters.md |
Fixes/extends pull-mode documentation (optimum-cli params) and updates embeddings pooling option docs. |
dtrawins
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-172618