Repository navigation
Conversation
|
@tokainz is attempting to deploy a commit to the njevric's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since 4.4.1 the Password input has aria-expanded. A password field has no ARIA role, and aria-expanded is only allowed on roles like combobox or button. axe (for example the Storybook a11y addon) therefore reports aria-allowed-attr.
This is a regression: aria-expanded was removed before, but added back in 36338d5.
The fix:
The fix is just removing the aria-expanded from the input.
Why not aria-describedby as suggested in the linked PR of the Issue:
Out of scope but worth a look in another PR:
aria-live="polite") and in the hidden live region.aria-haspopupon the input androle="dialog"on the overlay don’t really fit either. The overlay is informational, not interactive, and focus never moves into it.Related issue
Closes #132
Checklist
pnpm run lintandpnpm run formatpass## [Unreleased]inCHANGELOG.md(skip for internal refactors, tests, CI, and docs typos)