Repository navigation
Conversation
|
@tokainz is attempting to deploy a commit to the njevric's projects Team on Vercel. A member of the Team first needs to authorize it. |
…open for nested overlays
tokainz
force-pushed
the
fix/treeselect-outside-click
branch
from
November 20, 2026 21:08
d0be913 to
f0b3b0e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two problems with the outside click handling of
TreeSelect.Two outside clicks needed after a click into the panel outside the tree (#735)
onOverlayClicksetselfClick = truein the bubble phase. Since the outside click listener runs in the capture phase (f6293cf), this happened after the listener had already run, soselfClickswallowed the next click instead, even when it was outside. Clicks on the tree are not affected, because the tree stops their propagation. In the capture phase the click target is still in the DOM when the listener runs, soisOutsideClicked()already handles clicks inside the panel.onOverlayClickno longer setsselfClick. It still emitsoverlay-click.Nested overlays (#736)
Same fix as for
DatePicker,MultiSelect,AutoComplete,SelectandCascadeSelect:TreeSelectlistens tooverlay-clickwhile its panel is open. If the event comes from a component inside its panel, it setsselfClickand ignores the following outside click.Selectemitsoverlay-clickonmousedown, so this also works when theSelecthas already closed by the time theclickevent arrives.isNestedOverlayVisible()checks for an open overlay inside the panel. While the nestedSelectis open, a click outside closes only theSelect. A second click closes theTreeSelect.The listener is removed in
onOverlayLeaveandbeforeUnmount. Like inCascadeSelect, the tree nodes aretreeitems witharia-expanded, soisNestedOverlayVisible()skips them ([aria-expanded="true"]:not([role="treeitem"])).Tests
There was no spec for
TreeSelectyet. The newTreeSelect.spec.jscovers the same 5 nested overlay tests as the other components, plus a test for the first outside click after a click inside the panel and one for an outside click while a node is expanded.Verified manually in the showcase: after a click on the footer content, the first click outside closes the panel. Expanding and collapsing nodes keeps the panel open, selecting a node still closes it. Picking an option in a nested
Selectkeeps the panel open, whether theSelectwas opened with the mouse or the keyboard.Related issue
Closes #735
Closes #736
Checklist
pnpm run lintandpnpm run formatpass## [Unreleased]inCHANGELOG.md