Repository navigation
Conversation
|
@tokainz is attempting to deploy a commit to the njevric's projects Team on Vercel. A member of the Team first needs to authorize it. |
tokainz
force-pushed
the
fix/select-nested-overlay-click
branch
from
November 20, 2026 21:06
f03f2e9 to
cacb6c8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A
Selectin theheaderorfooterslot of anotherSelectclosed the outerSelectwhen you picked one of its options. The panel of the innerSelectis attached tobody, so the outside click listener of the outerSelecttreated the click as an outside click.This applies the same fix as in
DatePicker(#571),MultiSelect(#718) andAutoComplete(#721):Selectlistens tooverlay-clickwhile its panel is open. If the event comes from a component inside its panel, it setsselfClickand ignores the following outside click.Selectemitsoverlay-clickonmousedown, so this also works when the innerSelecthas already closed by the time theclickevent arrives.isNestedOverlayVisible()checks for an open overlay inside the panel ([aria-expanded="true"]). While the innerSelectis open, a click outside closes only the innerSelect. A second click closes the outer one.The listener is removed in
onOverlayLeaveandbeforeUnmount. SinceSelecthas noisOutsideClicked()method, both checks are added to the existingcomposedPathcondition in the outside click listener.Tests: added a
nested overlaysblock toSelect.spec.jswith the same 5 tests as forMultiSelectandAutoComplete. Without the fix, 2 of them fail.Verified manually in the showcase with a
Selectin the header of anotherSelect. Picking an option of the outerSelectitself still selects it and closes the panel as before.Related issue
Closes #731
Checklist
pnpm run lintandpnpm run formatpass## [Unreleased]inCHANGELOG.md