Repository navigation
Adopt Topiary 5.93.6 for saved-policy fidelity - #583
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved ranking expressions could change candidate selection after YAML reload:
10 - (3 - 1)lost its grouping, andclip(-1, 1)ignored the negative lower bound. Require published Topiary >=5.93.6,<6.0.0, which contains the rendering, signed-argument and scalar-literal compatibility fixes from openvax/topiary#473, openvax/topiary#475 and openvax/topiary#481.Add four consumer regressions covering both
reprandto_expr_string. They load rendered expressions through Vaxrank YAML configuration, assert scores and eligibility, retain rejected occurrences, and save/replay complete policy evidence. All four reproduce incorrect selection on published Topiary 5.93.3 and pass on published 5.93.6. Version: 3.38.3.Validation: lint; all 2,164 tests (39 existing warnings); B16 real VCF/BAM smoke with reports and peptide/mRNA outputs; wheel/sdist metadata and strict Twine checks passed against published Topiary 5.93.6. GitHub CI must pass before merge, followed immediately by clean-main deployment and public PyPI verification.
Closes #582.