Repository navigation
Make native mutation datasets portable with verified references - #573
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native mutation archives currently reopen the original annotation database while restoring supporting transcripts, so moving a result or deleting its temporary reference can prevent scoring and construct replay. This change restores transcript metadata lazily using released PyEnsembl 2.22.2 and exports custom-reference resources into a verified, relative sibling bundle.
Loading verifies size/SHA-256, preserves the exact reference/gene/transcript identity, and never substitutes an old path or another release. Missing resources still allow retained evidence and construct replay; annotation indexing is an explicit local-only operation. Saved protein IDs avoid annotation lookups during construct replay, including legacy archives with matching recorded transcript provenance. Evidence-only re-save retains the expected resource checksums.
Standard Ensembl release/species identity remains intact, with explicitly attached local DNA bundled. Move the native CSV/TSV and its
.referencesdirectory together for annotation work; bundle size reflects the custom reference resources supplied.Validation: lint passes; 24 focused regressions pass, including both BAM strands, fresh-process relocation, actual annotation/effect queries, legacy archives, missing/tampered resources, attached reference DNA, and CLI peptide/mRNA FASTA plus PDF output. The final full suite passes: 2,135 tests, with the existing 38 expected warnings.
Closes #563. Upstream lazy locus restoration shipped in openvax/pyensembl#436 (fixes openvax/pyensembl#435), published as 2.22.2. Vaxrank version: 3.37.2.