Repository navigation
Fix RNA variant support caching - #577
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RNAReadPhasingSource.supports_variant()saved counts under the lastsequencing-template key instead of the variant key. Repeated calls therefore
rescanned the BAM even when the support count was already known. Keep
variant_keyandfragment_keyseparate so each allele caches its own count,including zero and missing-contig results.
Regressions verify interleaved variants (including different alts at one
locus), equivalent Variant instances, RG/QNAME template grouping, overlapping
mates, informative conflicts and quality/flag filters. They also verify that
new haplotype registration invalidates support and phase caches when counts
increase or decrease, while duplicate registration retains the cache. The
audited real Sid NTF3 and EXOC4 cases now assert one support fetch per variant
through repeated support, evidence and resolver queries. Allele calling and
fragment filtering are unchanged. Bump the patch version to 10.11.7.
Closes #575.
Validation:
their count assertions passed.
./lint.sh: passed.TEST_SH_MAX=2 ./test.sh: 3,240 passed (22 existing warnings).