Repository navigation
Verify real Sid RNA phasing through protein effects - #576
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real Sid RNA phasing is now tested through
VariantCollection.effects(), sothe tests verify the protein produced by a phased combination, as well as the
read evidence establishing that combination. NTF3's two individually predicted
p.K56R/p.K56Nedits yieldAAG>AGT,p.K56Sand the independently expectedDVSENYpeptide when the real reads establish cis. Real trans evidence andinsufficient support retain separate DNA predictions and no joint prediction.
Extend this to MAP2's two substitutions plus a 28-base deletion using the
existing anchored-sequence evidence API. Original T1/T2 bulk RNA witnesses with
28Ngaps support the same local compound sequence as the single T2 ONT witnesswith
22D2M6D; only the bulk evidence clears the unchanged two-template floor.The combined 904-aa reference-frame protein is checked independently. Corrected
complex, deletion-only and historical 22-base alleles remain distinct, with
their DNA predictions retained even when their RNA hypotheses do not match.
pinned neutral openvax-v2 bundle; verify record digest multiplicities against
the complete source subset, including mates and supplementary placements.
RefSeq mRNA/protein and GRCh38 genomic records. Pin source receipts, CDS edits,
codons, full protein/CDS hashes and stops; no Varcode/PyEnsembl imports were
used to derive the expected effects.
established fast/protein_diff annotators. Verify individual effects across
transcripts and joint membership/protein/phase provenance after JSON.
10.11.6. This adds integration coverage and references; runtime semantics,
dependencies and global phasing thresholds are unchanged.
Validation:
./lint.shpasses; 99 focused phasing/haplotype/packaging testspass; full
TEST_SH_MAX=2 ./test.shpasses with 3,234 tests (22 existingwarnings, 219.34s). Fixture inventory and source-distribution checks pass.
Refs #464. The audit reproduced existing defects filed separately as #574
(experimental effect JSON drops realized candidates/hypotheses/products) and
#575 (RNA support cache uses the final fragment key). Experimental complete-CDS
checks use in-memory products; JSON checks assert its currently preserved
protein, membership and phase source. Returned support counts are correct in
these fixtures. This PR does not claim completion of the broader #464 panel.