Test RNA phasing on complete real Sid templates - #573
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Varcode's shared Sid tests covered mutation targets and junction records, but RNA phasing still relied on synthetic alignments. Add integration tests using three verified
openvax-v2members: paired short-read NTF3, ONT NTF3, and ONT EXOC4.The tests pin independently audited fragment counts and exercise cis, trans, unknown phase, minimum-fragment thresholds, both query orders, and
MolecularPhaseResolver. They compare exact record multiplicities with the manifest and with every record of each selected RG/QNAME in the bundle source, checking mate retention and supplementary-record filtering. The test guide records sources, alleles, expectations, evidence settings, and reproduction. Companion alleles are RNA observations, without an assumed germline/somatic classification.Validation:
./lint.shpassed; the new integration coverage and existing phasing tests passed (70 tests);TEST_SH_MAX=2 ./test.shpassed (3,205 tests). GitHub's existing Python 3.9–3.11 matrix also runs these tests from the source distribution.Patch release: 10.11.5.
Closes #528.