Repository navigation
Preserve splice-ambiguous event hypotheses in dense discovery - #442
Merged
Merged
Conversation
|
coverage: 96.547%. remained the same — fix/dense-splice-ambiguous-priority into master |
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dense discovery can spend its representative budget on other event context before
retaining splice-ambiguous event joins. In the Sid ::IGKC replay, none of the 487
original witness records for a previously retained short hypothesis reached the
dense discovery set; those joins were ranked as ordinary novel context.
Prioritize
_join_class's deliberately deferred (lazy) event-compatible joinsalongside other placed event joins. Their existing splice-ambiguity classification
and full-input support counting remain intact. Bump to 1.44.1.
The regression fails on the released engine: abundant breakpoint clips exhaust
a two-record discovery budget before a splice-ambiguous candidate. With this fix,
the candidate survives and all seven original fragments/cells without qualities
are counted. Lint, all 14 dense regressions, and all 5,700 tests pass (97% coverage).
The original-engine regression fails and the corrected engine preserves the
splice-ambiguous hypothesis. GitHub CI must pass before merge/deploy.
Fixes #441. Required by the real-data #437 integration in #433; the initial and
corrected Sid replays will be kept separately.