Repository navigation
Add GTF parsing progress and fix attribute data loss (2.9.0) - #82
Merged
Merged
Conversation
Coverage Report for CI Build 36578137748Coverage increased (+1.1%) to 96.751%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions4 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large GTF reads expose no progress hook, and attribute parsing silently truncates values such as
"two words"and"part1; part2". Add optionalprogress_callback(stage, completed, total)hooks and preserve complete quoted values, including apostrophes and semicolons. Release as 2.9.0.Callbacks report
read,attributes, andconvert. Attribute expansion reports every 10,000 rows; opaque Polars operations report start/completion with an initially unknown total. The default stays silent with no progress UI dependency. Document the contract and an executable tqdm adapter; propagate cancellation/errors without false completion events.Also preserve raw attribute text, treat missing attribute fields as empty, and reject invalid
result_typebefore reading input. Retain explicitfix_quotes_columnscleanup as an opt-in compatibility option. Update writer round-trip coverage for quoted values. Embedded unescaped double quotes and literal tabs/newlines remain outside writer guarantees.Validation:
./lint.shpasses../test.sh -W error::DeprecationWarning: 143 passed on Polars 1.44.2 and 1.32.0; 142 passed and one modern-only skip on 1.31.0. Coverage: 96%, attribute parser: 100%.Fixes #80. Fixes #23. Fixes #44. Fixes #81. Addresses the invalid-result-type bug and related touched docstrings in #76; leaves its unrelated cleanup open.
Release verification (2026-09-29): merged as
9a281c1. Ran./deploy.shfrom clean master; lint and all 143 tests passed. gtfparse 2.9.0 is published. Both PyPI artifact SHA-256 digests match the local build. Reinstalled the PyPI wheel into an isolated environment and verified every installed package source matches the release wheel. Smoke checks passed with deprecations as errors for progress events, quoted values, missing attributes, raw preservation, invalid result types, and gzip round trips. All five CI matrix jobs and combined coverage checks passed before merge.Tracked the non-blocking setuptools license-metadata build warning separately in #83. Follow-up gtfparse work can address packaging/cleanup (#83, remaining #76) and stale issue triage (#75) before larger configurable synthesis/validation changes (#65/#66).