Repository navigation
Fix deprecated Polars string cache calls (2.8.1) - #78
Merged
Merged
Conversation
Coverage Report for CI Build 36460031071Coverage increased (+0.02%) to 95.635%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions4 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reading a GTF on Polars 1.41+ emits a deprecated string-cache warning and fails when callers treat deprecations as errors. Skip the obsolete setter when
polars.Categoriesis available; retain the shared cache on older Polars so categorical columns from separate reads remain compatible.Add regression coverage for repeated pandas/Polars reads, categorical joins across separate lazy frames, and avoiding global cache setters on modern Polars. CI runs deprecations as errors and covers both sides of the Categories transition (1.31.0 and 1.32.0), alongside the latest compatible Polars on Python 3.9–3.11. Aggregate coverage from the three Python 3.11 Polars jobs so both modern and legacy paths count toward the coverage gate. Bump the package to 2.8.1.
Validation:
-W error::DeprecationWarning../lint.shpasses../test.sh -W error::DeprecationWarning: 89 passed on Polars 1.44.2; 88 passed and 1 modern-only skip on Polars 1.31.0; 89 passed on Polars 1.32.0.Fixes #77. Fixes #79.
Release verification (2026-09-28): merged as
46753d8;./deploy.shran successfully from clean master, passing lint and all 89 tests. gtfparse 2.8.1 is published. Both PyPI artifact SHA-256 digests match the local build. Installing the published wheel into an isolated environment and reading pandas/Polars outputs with deprecations as errors also passed. All matrix CI jobs and combined coverage checks passed before merge.