Add transactional archive directory installs - #86
Merged
Merged
Conversation
Coverage Report for CI Build 36768096745Coverage decreased (-2.4%) to 93.114%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Coverage Report for CI Build 36808213563Coverage decreased (-2.4%) to 93.174%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MHCflurry's tar downloads need the entire extracted tree and source receipt to become available together. An interrupted extraction into the final directory can leave partial data that looks installed. This adds a shared archive installer that validates in private staging, then publishes a complete immutable generation and an atomic current pointer.
install_archive/inspect_archivesupport full tar trees, ordered split parts, local predownloaded parts, and trusted aggregate or per-part checksums. Historical sources explicitly opt into observed-receipt verification.VersionedArchiveRegistrysupplies concrete versions and defaults, progress/retry forwarding, offline paths, inspection, and source/hash/time status. A layout callback and transactionalextra_filessupport MHCflurry's release layout andDOWNLOAD_INFO.csv../components, then reject traversal, links, special files, reserved names, and duplicate/case-folded collisions. Header scanning stops immediately when member or expansion limits are exceeded; FIFO sources fail without blocking.VersionedFileRegistry.status()also exposes recorded URLs and observed SHA-256, and the integration guide documents reusable fixed-file, archive-tree, and multi-file APIs for downstream libraries.Validation:
./test.shpasses all 807 tests with 93% overall coverage; lint and diff checks pass. Regression tests cover standard tar paths and collisions, a 12,000-file manifest with offline recovery, early resource-limit rejection, FIFO input, metadata removal/changes, and invalid receipt rejection before publication. All CI test jobs pass on Linux Python 3.9–3.14, macOS, and focused Windows archive tests. The non-required Coveralls comparison reports lower overall coverage than the base branch after adding the archive module.Closes #85