Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements issue #116 by propagating operation “category” into scenario graph node data and surfacing it in the node UI (as a “Client” badge / field), so mixed-client scenarios are visually distinguishable.
Changes:
- Add
categorytoNodeDataand propagateoperation.categoryin YAML→graph conversion and drag/drop node creation. - Render a client/category badge in
CustomNodeand show client info in the Properties panel. - Add unit tests for category propagation and UI badge rendering.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| web-editor/src/utils/scenarioConversion.ts | Propagates category from Operation into node data during YAML→graph conversion. |
| web-editor/src/utils/tests/scenarioConversion.test.ts | Adds tests verifying category is set/undefined appropriately (including group child steps). |
| web-editor/src/types/scenario.ts | Extends NodeData with optional category. |
| web-editor/src/styles/Node.module.css | Adds styling for the client/category badge. |
| web-editor/src/hooks/useScenarioGraph.ts | Sets category when creating nodes via drag/drop. |
| web-editor/src/components/ScenarioEditor/PropertiesPanel.tsx | Displays client/category for the selected node. |
| web-editor/src/components/ScenarioEditor/CustomNode.tsx | Renders a client/category badge on the node. |
| web-editor/src/components/ScenarioEditor/tests/CustomNode.test.tsx | Adds tests for conditional rendering of the client badge. |
| .vite/deps/package.json | Adds Vite cache artifact (should not be committed). |
| .vite/deps/_metadata.json | Adds Vite cache artifact (should not be committed). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #116