Conversation
stakira
commented
Jun 17, 2026
stakira
commented
Collaborator
- Remove time axis from expression area
- Fix portrait positioning
- Fix portrait covered by expression track background
- Fix expression track background alternating color
- Auto hide notes properties scroll bar
- Remove time axis from expression area - Fix portrait positioning - Fix portrait covered by expression track background - Fix expression track background alternating color - Auto hide notes properties scroll bar
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets several piano roll UI regressions/rough edges, primarily around expression-area visuals and singer portrait layout, plus a small usability tweak in note properties.
Changes:
- Reworked
TickBackgroundto support toggling bar/time-axis rendering via a renamedShowBarproperty, and updated call sites. - Adjusted piano roll XAML layering/structure so expression backgrounds can render beneath the portrait and the expression area no longer reserves space for the time axis.
- Tweaked portrait positioning logic in code-behind and enabled auto-hiding note-properties scrollbars.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| OpenUtau/Views/MainWindow.axaml | Updates TickBackground usage to the new ShowBar property. |
| OpenUtau/ViewModels/NotesViewModel.cs | Updates expression-descriptor selection logic and expression track sizing behavior. |
| OpenUtau/Controls/TickBackground.cs | Renames and implements ShowBar to control bar/time-axis drawing and invalidation. |
| OpenUtau/Controls/PianoRoll.axaml.cs | Adds runtime portrait positioning updates tied to layout changes. |
| OpenUtau/Controls/PianoRoll.axaml | Reorders/adds backgrounds and portrait container; removes expression time-axis margin. |
| OpenUtau/Controls/NotePropertiesControl.axaml | Enables scrollbar auto-hide for the note properties panel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+172
to
174
| } else { | ||
| ExpTrackHeight = 0; | ||
| } |
Comment on lines
+65
to
70
| private void UpdatePortraitPosition() { | ||
| if (PortraitImage.DesiredSize.Width == 0 || PortraitCanvas.Bounds.Width == 0) return; | ||
| // Position at top-right of row 3, with 100px margin from right | ||
| Canvas.SetTop(PortraitImage, 0); | ||
| Canvas.SetLeft(PortraitImage, PortraitCanvas.Bounds.Width - PortraitImage.DesiredSize.Width - 100); | ||
| } |
keirokeer
pushed a commit
to keirokeer/OpenUtau-lunai
that referenced
this pull request
Jun 18, 2026
- Remove time axis from expression area - Fix portrait positioning - Fix portrait covered by expression track background - Fix expression track background alternating color - Auto hide notes properties scroll bar
keirokeer
added a commit
to keirokeer/OpenUtau-lunai
that referenced
this pull request
Jun 18, 2026
Integrate upstream openutau#2207 piano roll UI fixes while preserving Lunai workspace layout, playback highlight, and note properties redesign.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.