Skip to content
This repository was archived by the owner on Jul 15, 2026. It is now read-only.

ci: add cspell spell check workflow and make target - #9

Merged
Umaaz merged 2 commits into
mainfrom
ci/spellcheck
Feb 24, 2026
Merged

Umaaz merged 2 commits into
mainfrom
ci/spellcheck

Conversation

@Umaaz

@Umaaz Umaaz commented Feb 24, 2026 •

Copy link
Copy Markdown
Contributor

Overview

This merge request introduces an automated spell-checking workflow using cspell to improve the quality and consistency of our codebase and documentation. It adds a GitHub Actions workflow that runs on pull requests to main and provides a make spellcheck target for developers to run checks locally.

Technical Details

  • GitHub Actions Workflow (.github/workflows/spellcheck.yml):

    • A new CI workflow is added that triggers on pull requests targeting the main branch.
    • It uses the streetsidesoftware/cspell-action to perform the spell check.
  • Configuration (cspell.json):

    • A configuration file is included to customize cspell's behavior.
    • It specifies the language, defines paths to ignore, and contains a project-specific dictionary of allowed words.
  • Local Execution (Makefile):

    • A spellcheck target is added to the Makefile.
    • Developers can run make spellcheck to execute the same checks locally, ensuring consistency with the CI pipeline.

Review Summary

  • Key Findings: The initial implementation had a discrepancy where the local make spellcheck command used a less comprehensive file pattern than the CI workflow.
  • Resolution: The suggested change to use a more inclusive glob pattern ("**/*") was adopted for the local command. This ensures that local and CI environments run identical checks, preventing inconsistencies.
  • Approval Status: Approved.

Impact Assessment

  • Security: No security impact.
  • Performance: Adds a new, fast-running check to the CI pipeline. This has a negligible effect on pipeline duration and no impact on application performance.
  • Maintainability: Positive impact. By catching typos early, this change enhances the readability and professionalism of our code and documentation, making the project easier to maintain.

Attached by run d790fd5b-8705-4dbf-a2b1-dc1d83e0db06

Adds a GitHub Actions workflow that runs cspell on pushes to main and
PRs. Includes a cspell.json config with project-specific dictionary
and a `make spellcheck` target for local use.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@Umaaz
Umaaz requested review from AnysSido and Edwinbhart February 24, 2026 21:27
@Umaaz Umaaz added the review label Feb 24, 2026
@Umaaz
Umaaz enabled auto-merge (squash) February 24, 2026 21:28
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ghost ghost added the Aether::Approved label Feb 24, 2026

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ghost

ghost commented Feb 24, 2026

Copy link
Copy Markdown

This is a great addition to the CI pipeline. Adding an automated spell check will help maintain the quality of our documentation and code comments. The inclusion of a make spellcheck target for local testing is also a welcome feature.


Attached by run j-69d8d884-602d-4ba9-81e4-284d6c79f3de

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed via automated analysis.

Comment thread Makefile
@ghost

ghost commented Feb 24, 2026

Copy link
Copy Markdown

This is a great addition to the CI pipeline. Adding an automated spell check will help maintain the quality and professionalism of the codebase and its documentation. The inclusion of a make target for local use is also a good practice.


Attached by run d790fd5b-8705-4dbf-a2b1-dc1d83e0db06

@Umaaz
Umaaz merged commit cefa280 into main Feb 24, 2026
1 check passed
@Umaaz
Umaaz deleted the ci/spellcheck branch February 24, 2026 21:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants