ci: verify-installer speaks Squirrel — the setup exe lives in dist/squirrel-windows, --silent not /S, the versioned app-<ver> folder holds the payload, Update.exe --uninstall - #144
Open
kai-openswarm wants to merge 1 commit into
Conversation
…uirrel-windows, --silent not /S, the versioned app-<ver> folder holds the payload, Update.exe --uninstall The verifier still described the NSIS installer while win.target has been Squirrel: it looked for dist/OpenSwarm-Setup-x64.exe (Squirrel writes dist/squirrel-windows/), installed with /S (which Squirrel ignores, opening a UI that waits forever), asserted %LOCALAPPDATA%/Programs/OpenSwarm (Squirrel installs a stub beside app-<ver>/ under %LOCALAPPDATA%/OpenSwarm) and looked for 'Uninstall OpenSwarm.exe' (Squirrel registers Update.exe --uninstall). The e2e installer job failed at the first of these on a clean runner. Same conventions smoke-windows-packaged.yml already uses; every check the verifier made is kept. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scripts/ci/verify-installer.jsstill described the NSIS installer whilewin.targethas been Squirrel:dist/OpenSwarm-Setup-x64.exe(Squirrel writesdist/squirrel-windows/), so the e2einstallerjob failed at artifact discovery on a clean runner ("no Setup.exe found; build first or pass --setup");/S, which Squirrel ignores — it opens a UI and waits for a click that never comes;%LOCALAPPDATA%\Programs\OpenSwarm(Squirrel installs a stub beside a versionedapp-<ver>\under%LOCALAPPDATA%\OpenSwarm);Uninstall OpenSwarm.exe(Squirrel registersUpdate.exe --uninstall).This ports the verifier to the same Squirrel conventions
smoke-windows-packaged.ymlalready uses (--silent, the versioned app folder,Update.exe --uninstall, the release alias indist/still accepted). Every check the verifier made is kept: artifact size + PE header, install dir, payload (resources,locales), registry uninstall entry, uninstaller on disk, shortcuts, uninstall removes the app, user data preserved.Verified
Full
--destructive --forcerun on a GitHub-hostedwindows-latestrunner against a fresh build:dist/squirrel-windows/OpenSwarm-Setup-x64.exe(393 MB, valid PE) →--silentinstall completed →app-1.7.7\OpenSwarm.exe+resources+localespresent → uninstall registry entry +Update.exe+ desktop shortcut asserted →Update.exe --uninstallremoved the app → user data preserved.verify-all --app <installed exe>boot gate: on hosted Windows the packaged app cold-boots well past that gate's budgets (first paint measured at 76–238 s across runs), andverify-all's own packaging-parity check reports "staged on Mac but not Win: mouseclamp, python-env". Both are independent of this port and worth their own look; the verifier itself now does what it says on that runner.