Skip to content

Commit dbc9869

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "typing: Add types for _get_columns helpers"
2 parents 29013e1 + 5470d30 commit dbc9869

37 files changed

Lines changed: 181 additions & 42 deletions

openstackclient/network/v2/address_group.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
from typing import Any
2020

2121
import netaddr
22+
from openstack.network.v2 import address_group as _address_group
2223
from osc_lib import exceptions
2324
from osc_lib import utils
2425

@@ -30,7 +31,9 @@
3031
LOG = logging.getLogger(__name__)
3132

3233

33-
def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
34+
def _get_columns(
35+
item: _address_group.AddressGroup,
36+
) -> tuple[tuple[str, ...], tuple[str, ...]]:
3437
hidden_columns = ['location', 'tenant_id']
3538
return utils.get_osc_show_columns_for_sdk_resource(
3639
item, {}, hidden_columns

openstackclient/network/v2/address_scope.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
from collections.abc import Iterable, Sequence
1919
from typing import Any
2020

21+
from openstack.network.v2 import address_scope as _address_scope
2122
from osc_lib import exceptions
2223
from osc_lib import utils
2324

@@ -29,7 +30,9 @@
2930
LOG = logging.getLogger(__name__)
3031

3132

32-
def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
33+
def _get_columns(
34+
item: _address_scope.AddressScope,
35+
) -> tuple[tuple[str, ...], tuple[str, ...]]:
3336
column_map = {
3437
'is_shared': 'shared',
3538
}

openstackclient/network/v2/bgpvpn/bgpvpn.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import logging
1919
from typing import Any
2020

21+
from openstack.network.v2 import bgpvpn as _bgpvpn
2122
from osc_lib.cli import format_columns
2223
from osc_lib.cli import identity as osc_id
2324
from osc_lib.cli.parseractions import KeyValueAction
@@ -60,7 +61,9 @@
6061
}
6162

6263

63-
def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
64+
def _get_columns(
65+
item: _bgpvpn.BgpVpn,
66+
) -> tuple[tuple[str, ...], tuple[str, ...]]:
6467
column_map: dict[str, str] = {}
6568
hidden_columns = ['location', 'tenant_id']
6669
return osc_utils.get_osc_show_columns_for_sdk_resource(

openstackclient/network/v2/bgpvpn/network_association.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818
import logging
1919
from typing import Any
2020

21+
from openstack.network.v2 import (
22+
bgpvpn_network_association as _bgpvpn_network_association,
23+
)
2124
from osc_lib.cli import identity as osc_id
2225
from osc_lib.cli import parseractions
2326
from osc_lib import exceptions
@@ -38,7 +41,9 @@
3841
_formatters: dict[str, Any] = {}
3942

4043

41-
def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
44+
def _get_columns(
45+
item: _bgpvpn_network_association.BgpVpnNetworkAssociation,
46+
) -> tuple[tuple[str, ...], tuple[str, ...]]:
4247
column_map: dict[str, str] = {}
4348
hidden_columns = ['location', 'name', 'tenant_id']
4449
return osc_utils.get_osc_show_columns_for_sdk_resource(

openstackclient/network/v2/bgpvpn/port_association.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818
import logging
1919
from typing import Any
2020

21+
from openstack.network.v2 import (
22+
bgpvpn_port_association as _bgpvpn_port_association,
23+
)
2124
from osc_lib.cli import format_columns
2225
from osc_lib.cli import identity as osc_id
2326
from osc_lib.cli import parseractions
@@ -56,7 +59,9 @@
5659
}
5760

5861

59-
def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
62+
def _get_columns(
63+
item: _bgpvpn_port_association.BgpVpnPortAssociation,
64+
) -> tuple[tuple[str, ...], tuple[str, ...]]:
6065
column_map: dict[str, str] = {}
6166
hidden_columns = ['location', 'name', 'tenant_id']
6267
return osc_utils.get_osc_show_columns_for_sdk_resource(

openstackclient/network/v2/bgpvpn/router_association.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818
import logging
1919
from typing import Any
2020

21+
from openstack.network.v2 import (
22+
bgpvpn_router_association as _bgpvpn_router_association,
23+
)
2124
from osc_lib.cli import identity as osc_id
2225
from osc_lib.cli import parseractions
2326
from osc_lib import exceptions
@@ -43,7 +46,9 @@
4346
_formatters: dict[str, osc_utils.FormatterT] = {}
4447

4548

46-
def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
49+
def _get_columns(
50+
item: _bgpvpn_router_association.BgpVpnRouterAssociation,
51+
) -> tuple[tuple[str, ...], tuple[str, ...]]:
4752
column_map: dict[str, str] = {}
4853
hidden_columns = ['location', 'name', 'tenant_id']
4954
return osc_utils.get_osc_show_columns_for_sdk_resource(

openstackclient/network/v2/default_security_group_rule.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818
from collections.abc import Iterable, Sequence
1919
from typing import Any
2020

21+
from openstack.network.v2 import (
22+
default_security_group_rule as _default_security_group_rule,
23+
)
2124
from osc_lib.cli import parseractions
2225
from osc_lib import exceptions
2326
from osc_lib import utils
@@ -30,7 +33,9 @@
3033
LOG = logging.getLogger(__name__)
3134

3235

33-
def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
36+
def _get_columns(
37+
item: _default_security_group_rule.DefaultSecurityGroupRule,
38+
) -> tuple[tuple[str, ...], tuple[str, ...]]:
3439
hidden_columns = ['location', 'name', 'revision_number']
3540
return utils.get_osc_show_columns_for_sdk_resource(
3641
item, {}, hidden_columns

openstackclient/network/v2/floating_ip.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
from typing import Any
1919

2020
from openstack import exceptions as sdk_exceptions
21+
from openstack.network.v2 import floating_ip as _floating_ip
2122
from osc_lib.cli import format_columns
2223
from osc_lib import exceptions
2324
from osc_lib import utils
@@ -35,7 +36,9 @@
3536
}
3637

3738

38-
def _get_network_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
39+
def _get_network_columns(
40+
item: _floating_ip.FloatingIP,
41+
) -> tuple[tuple[str, ...], tuple[str, ...]]:
3942
hidden_columns = ['location', 'tenant_id']
4043
return utils.get_osc_show_columns_for_sdk_resource(
4144
item, {}, hidden_columns

openstackclient/network/v2/floating_ip_port_forwarding.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
from collections.abc import Iterable, Sequence
1919
from typing import Any
2020

21+
from openstack.network.v2 import port_forwarding as _port_forwarding
2122
from osc_lib import exceptions
2223
from osc_lib import utils
2324

@@ -91,7 +92,9 @@ def validate_port(port: int) -> None:
9192
raise exceptions.CommandError(msg)
9293

9394

94-
def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
95+
def _get_columns(
96+
item: _port_forwarding.PortForwarding,
97+
) -> tuple[tuple[str, ...], tuple[str, ...]]:
9598
hidden_columns = ['location', 'tenant_id']
9699
return utils.get_osc_show_columns_for_sdk_resource(
97100
item, {}, hidden_columns

openstackclient/network/v2/ip_availability.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
from collections.abc import Iterable, Sequence
1818
from typing import Any
1919

20+
from openstack.network.v2 import network_ip_availability as _ip_availability
2021
from osc_lib.cli import format_columns
2122
from osc_lib import utils
2223

@@ -29,7 +30,9 @@
2930
}
3031

3132

32-
def _get_columns(item: Any) -> tuple[tuple[str, ...], tuple[str, ...]]:
33+
def _get_columns(
34+
item: _ip_availability.NetworkIPAvailability,
35+
) -> tuple[tuple[str, ...], tuple[str, ...]]:
3336
hidden_columns = ['id', 'name', 'location', 'tenant_id']
3437
return utils.get_osc_show_columns_for_sdk_resource(
3538
item, {}, hidden_columns

0 commit comments

Comments
 (0)