Merge "typing: Require typed defs"

Author: Zuul

openstackclient/identity/v3/identity_provider.py

@@ -31,7 +31,9 @@
 LOG = logging.getLogger(__name__)
 
 
-def _format_identity_provider(idp):
+def _format_identity_provider(
+    idp: Any,
+) -> tuple[tuple[str, ...], tuple[Any, ...]]:
     columns = (
         'authorization_ttl',
         'description',

openstackclient/identity/v3/mapping.py

@@ -32,7 +32,7 @@
 LOG = logging.getLogger(__name__)
 
 
-def _format_mapping(mapping):
+def _format_mapping(mapping: Any) -> tuple[tuple[str, ...], tuple[Any, ...]]:
     columns = ('id', 'rules', 'schema_version')
     column_headers = ('id', 'rules', 'schema_version')
     return (

openstackclient/image/v2/metadef_namespaces.py

@@ -358,7 +358,7 @@ def take_action(
 class UnsetMetadefNamespace(command.Command):
     _description = _("Unset metadef namespace tags")
 
-    def get_parser(self, prog_name):
+    def get_parser(self, prog_name: str) -> argparse.ArgumentParser:
         parser = super().get_parser(prog_name)
         parser.add_argument(
             "namespace",
@@ -385,7 +385,7 @@ def get_parser(self, prog_name):
         )
         return parser
 
-    def take_action(self, parsed_args):
+    def take_action(self, parsed_args: argparse.Namespace) -> None:
         image_client = self.app.client_manager.image
 
         namespace = image_client.get_metadef_namespace(parsed_args.namespace)

pyproject.toml

@@ -786,9 +786,14 @@ ignore_missing_imports = true
 follow_imports = "normal"
 incremental = true
 check_untyped_defs = true
+disallow_untyped_defs = true
 warn_unused_ignores = true
 exclude = "(?x)(doc | examples | hacking | releasenotes)"
 
+[[tool.mypy.overrides]]
+module = ["openstackclient.tests.functional.*"]
+disallow_untyped_defs = false
+
 [[tool.mypy.overrides]]
 module = ["openstackclient.tests.unit.*"]
 ignore_errors = true