Skip to content

Conversation

@lmiccini
Copy link
Contributor

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lmiccini
Once this PR has been reviewed and has the lgtm label, please assign rabi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/56ac80bd0e7547ad88350eb0206886b5

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 18m 47s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 37m 31s
adoption-standalone-to-crc-ceph-provider FAILURE in 3h 01m 55s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 51m 23s
openstack-operator-docs-preview POST_FAILURE in 2m 32s

@stuggi stuggi requested a review from slagle January 28, 2026 08:13
lmiccini and others added 5 commits January 29, 2026 03:59
When using LOCAL_REGISTRY=1 with operator replace directives pointing to
personal forks (e.g., lmiccini/*), the script was trying to query the local
registry for bundle images that don't exist there, causing curl to return
null and jq to fail with "Cannot iterate over null (null)".

Root cause: Bundle images from personal forks are only published to quay.io
in the user's namespace (e.g., quay.io/lmiccini/glance-operator-bundle) and
are NOT mirrored to the local CI registry. The local registry only contains
standard openstack-k8s-operators bundles.

The fix:
1. Check IMAGEBASE first (takes precedence for custom registry settings)
2. For replaced operators (GITHUB_USER != "openstack-k8s-operators"):
   - Always query quay.io with the user's namespace
   - Skip local registry entirely
3. For standard operators: use local registry when LOCAL_REGISTRY=1
4. Update curl logic to only query local registry for standard operators

This allows CI builds with depends-on to work correctly when the dependency
uses replace directives for operator APIs.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Add dataplane-specific logic to track and manage RabbitMQ user
finalizers for OpenStackDataPlaneNodeSet services. This includes:

- Service finalizer tracking in NodeSet status
- RabbitMQ user creation and cleanup logic
- Multi-cluster RabbitMQ support
- Comprehensive tests for finalizer management

This preserves the webhooks_warnings approach for webhook defaulting
and services controllers while adding only the dataplane-specific
RabbitMQ finalizer management functionality.
@lmiccini lmiccini force-pushed the nodeset_rmqu_finalizer_configmap branch from 04cc55a to 1698305 Compare February 2, 2026 20:59
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/db62c9cd33b34a538c7eccf243769b6a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 02m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 56s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 36m 03s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 46m 57s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 34m 08s
openstack-operator-docs-preview POST_FAILURE in 3m 15s

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2026

@lmiccini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/precommit-check 1698305 link true /test precommit-check
ci/prow/openstack-operator-build-deploy-kuttl-4-18 1698305 link true /test openstack-operator-build-deploy-kuttl-4-18
ci/prow/openstack-operator-build-deploy-kuttl 1698305 link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants