Refresh bench tooling and Claude profiles#1
Conversation
|
@codex review |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefreshes devcontainer configuration to align bench tooling and Claude profiles with the synchronized workBenches parent, updating runtime/tooling and mounting portable Claude account profiles where applicable. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR updates the simBench devcontainer setup to support shared/portable Claude account profiles as part of the bench tooling refresh and alignment with the synchronized workBenches parent.
Changes:
- Add a new devcontainer bind mount for
~/.claude-profilesinto the container user’s home directory.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c194e19196
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| "source=${localEnv:HOME}/.claude,target=/home/${localEnv:USER}/.claude,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude.json,target=/home/${localEnv:USER}/.claude.json,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude-profiles,target=/home/${localEnv:USER}/.claude-profiles,type=bind,consistency=cached", |
There was a problem hiding this comment.
Make the Claude profiles bind mount optional
When a developer opens this devcontainer on a host that has the existing Claude files but has not created ~/.claude-profiles, this new bind mount prevents the container from starting. I checked the Dev Container metadata reference and mounts strings use Docker --mount semantics; Docker rejects missing bind sources unless bind-create-src is used, so this turns an optional profile directory into a required local prerequisite.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c194e19196
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| "source=${localEnv:HOME}/.claude,target=/home/${localEnv:USER}/.claude,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude.json,target=/home/${localEnv:USER}/.claude.json,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude-profiles,target=/home/${localEnv:USER}/.claude-profiles,type=bind,consistency=cached", |
There was a problem hiding this comment.
Keep Claude profile bind mount optional
For hosts that already have ~/.claude and ~/.claude.json but have not created the non-standard ~/.claude-profiles directory, this new required bind mount prevents the dev container from starting: the Dev Containers metadata reference says mounts entries use Docker CLI --mount syntax, and Docker's bind-mount docs state that --mount errors when the source path does not exist. Please create the directory in initializeCommand or only add this mount when the host path exists.
Useful? React with 👍 / 👎.
Summary
Validation
git diff --checkbash -ndocker buildx build --checkSummary by Sourcery
Update the bench development environment to use refreshed runtime/tooling and shared Claude account profiles while keeping it aligned with the synchronized workBenches parent.
Enhancements:
Build: