-
Notifications
You must be signed in to change notification settings - Fork 0
Refresh bench tooling and Claude profiles #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,7 @@ cat >>"$OUT_FILE" <<YAML | |
| HIP_PATH: ${ROCM_ROOT} | ||
| HSA_ENABLE_DXG_DETECTION: "1" | ||
| HSA_ENABLE_SDMA: "0" | ||
| LD_PRELOAD: ${ROCM_ROOT}/lib/libhsa-runtime64.so.1 | ||
| ROCM_HSA_PRELOAD: ${ROCM_ROOT}/lib/libhsa-runtime64.so.1 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
On WSL AMD ROCm hosts, this generated override now only exports Useful? React with 👍 / 👎. |
||
| LD_LIBRARY_PATH: ${ROCM_ROOT}/lib:/usr/lib/x86_64-linux-gnu:/usr/lib | ||
|
Comment on lines
57
to
60
|
||
| YAML | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For hosts that have the existing credential paths but have not created
~/.claude-profiles, this new Dev Containers bind mount makes startup fail because entries inmountsuse Docker--mountsemantics and the bind source must already exist. Since the profiles are only useful for users who opted into portable Claude profiles, create the host directory before startup or make this mount conditional rather than requiring every devcontainer user to have it.Useful? React with 👍 / 👎.