Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh bench tooling and Claude profiles #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Refresh bench tooling and Claude profiles #1
Changes from all commits
2c7ad8c55fb877File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Devcontainer
mountsentries are passed as Docker--mountvalues, and--mount type=bindfails when the host source path does not exist. With this new unconditional bind, users who have the existing Claude config but have not created$HOME/.claude-profilescan no longer start the devcontainer until they manually create an empty directory; the same entry in the example config should be handled the same way, e.g. by ensuring the directory exists or using a create-safe mount option.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
Dockerfile.layer2runs this minimal installer at build time, resolving GitHub'sreleases/latestmakes the same checked-out commit install different tool versions depending on the build date and network response. For a bench image this breaks reproducible runs and can silently pull future major releases whilelayer.versionremains fixed; the hard-coded fallback is only used when the API lookup fails, not during normal builds. Please keep the refreshed versions explicit in the script or pass them as pinned build args instead of querying latest.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
Dockerfile.layer2runs this minimal installer to build the shared image, switching the formerly pinned download to GitHubreleases/latestmakes the same repo commit produce different toolchains as upstream projects publish releases. That breaks reproducibility for bench runs and can also make future rebuilds fail if a latest release changes asset names or archive layout; the script should keep explicit versions here or resolve them before committing.Useful? React with 👍 / 👎.
Check failure on line 17 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 29 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 44 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 57 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 73 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 88 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 99 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 118 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 131 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 144 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 155 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 168 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 183 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 199 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 214 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 225 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 240 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 255 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check failure on line 266 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Check warning on line 288 in install-ops-tools-minimal.sh
Define a constant instead of using the literal 's/.*\"v([^\"]+)\".*/\1/' 19 times.
Check warning on line 288 in install-ops-tools-minimal.sh
Define a constant instead of using the literal '\"tag_name\"' 19 times.
Check failure on line 289 in install-ops-tools-minimal.sh
Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.
Uh oh!
There was an error while loading. Please reload this page.