Refresh bench tooling and Claude profiles#1
Conversation
|
@codex review |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates devcontainer bench tooling to mount portable Claude profiles into the container and keeps devcontainer configuration in sync with the shared workBenches setup. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR updates the devcontainer configuration to make portable Claude account profiles available inside the bench environment, keeping local development tooling aligned with the bench’s refreshed runtime/admin setup.
Changes:
- Add a host bind mount for
~/.claude-profilesinto the devcontainer via docker-compose usermap configuration. - Add a matching bind mount for
~/.claude-profilesindevcontainer.jsonmounts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .devcontainer/docker-compose.usermap.yml | Adds ~/.claude-profiles volume mapping into the container home directory. |
| .devcontainer/devcontainer.json | Adds a devcontainer mount for ~/.claude-profiles to make profiles available in-container. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - ~/.claude:/home/${USER}/.claude:cached | ||
| - ~/.claude.json:/home/${USER}/.claude.json:cached | ||
| - ~/.claude-profiles:/home/${USER}/.claude-profiles:cached | ||
| - ~/.claude/.credentials.json:/home/${USER}/.claude/.credentials.json:cached |
| "source=${localEnv:HOME}/.claude,target=/home/${localEnv:USER}/.claude,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude.json,target=/home/${localEnv:USER}/.claude.json,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude-profiles,target=/home/${localEnv:USER}/.claude-profiles,type=bind,consistency=cached", | ||
| // Codex (OpenAI) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e975ed1917
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // Claude (Anthropic) | ||
| "source=${localEnv:HOME}/.claude,target=/home/${localEnv:USER}/.claude,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude.json,target=/home/${localEnv:USER}/.claude.json,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude-profiles,target=/home/${localEnv:USER}/.claude-profiles,type=bind,consistency=cached", |
There was a problem hiding this comment.
Avoid requiring optional Claude profiles
On any workstation that has the existing Claude/Codex config but no ~/.claude-profiles, this new active devcontainer mount prevents the container from being created: the devcontainer spec says mounts uses Docker --mount syntax, and Docker reports an error when a bind source path does not exist rather than creating it (see https://containers.dev/implementors/json_reference/ and https://docs.docker.com/engine/storage/bind-mounts/). If profiles are optional, create the directory in initializeCommand or make this mount opt-in so developers without that profile directory can still open the bench.
Useful? React with 👍 / 👎.
Summary
Validation
git diff --checkbash -ndocker buildx build --checkSummary by Sourcery
Enhancements: