Refresh bench tooling and Claude profiles#1
Conversation
|
@codex review |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR refreshes the devcontainer and layer2 Docker image configuration to align the bench environment with updated Claude profiles and the synchronized workBenches parent, including tooling/runtime updates for local development and administration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR refreshes the .NET bench container/tooling configuration to better align with the upstream workbench setup, including portable Claude profile mounting and updated Kubernetes tooling configuration.
Changes:
- Bumped Layer 2 image metadata version and parameterized the kubectl APT repo minor version in
Dockerfile.layer2. - Added a devcontainer bind mount for
~/.claude-profilesto support portable Claude account profiles.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Dockerfile.layer2 | Updates layer metadata and parameterizes the kubectl APT repository version. |
| .devcontainer/devcontainer.json | Adds a new bind mount for ~/.claude-profiles in the devcontainer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| LABEL layer.version="2.0.2" | ||
| LABEL layer.updated="2026-03-06" | ||
| LABEL layer.description=".NET development tools and SDK (user-agnostic)" |
| RUN curl -fsSL https://pkgs.k8s.io/core:/stable:/v${KUBERNETES_APT_MINOR}/deb/Release.key \ | ||
| | gpg --batch --yes --dearmor -o /etc/apt/keyrings/kubernetes-apt-keyring.gpg \ | ||
| && echo "deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/v1.32/deb/ /" \ | ||
| && echo "deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/v${KUBERNETES_APT_MINOR}/deb/ /" \ |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2cb6f3204
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "source=${localEnv:HOME}/.gemini,target=/home/${localEnv:USER}/.gemini,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude,target=/home/${localEnv:USER}/.claude,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude.json,target=/home/${localEnv:USER}/.claude.json,type=bind,consistency=cached", | ||
| "source=${localEnv:HOME}/.claude-profiles,target=/home/${localEnv:USER}/.claude-profiles,type=bind,consistency=cached", |
There was a problem hiding this comment.
Make optional Claude profile mount safe
For hosts that do not already have ~/.claude-profiles, this new devcontainer bind mount prevents the container from starting: devcontainer mounts entries use Docker --mount syntax, and Docker errors when a bind source path is absent. Since this profile directory only exists on machines that have opted into that layout, consider creating it in initializeCommand or otherwise making the mount safe; otherwise users who satisfied the previous credential mounts but have no profile directory can no longer open the bench.
Useful? React with 👍 / 👎.
Summary
Validation
git diff --checkbash -ndocker buildx build --checkSummary by Sourcery
Update devcontainer and layer2 Docker configuration to refresh bench tooling and align with current workbench setup.
Build: