Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh bench tooling and Claude profiles #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refresh bench tooling and Claude profiles #1
Changes from all commits
fe1976e27f8192File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On hosts that have the normal Claude files but have not created
~/.claude-profiles, this new bind mount can prevent the devcontainer from starting because Dev Containermountsare passed through as Docker bind mounts and the source path must already exist. The existinginitializeCommandcreates a few optional host directories, but it does not create this new Claude profiles directory, so users without that optional profile setup hit the failure before the container can run.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When users launch this image through the checked-in devcontainer,
.devcontainer/docker-compose.ymlstill setsCC=/usr/bin/gcc-12andCXX=/usr/bin/g++-12, and.devcontainer/devcontainer.jsonhas the same overrides; those environment values override the DockerfileENV. Since this change replaces the layer's GCC install/export with GCC 14 only, a fresh container can end up withCC/CXXpointing at non-existent GCC 12 paths, causing CMake and builds that honor these variables to fail immediately.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this layer is built on the still-documented Ubuntu 22.04/Jammy base, this
apt-get installstep cannot resolvegcc-14/g++-14from the stock repositories; Ubuntu's own GCC availability table lists Jammy packages only through GCC 12. Without moving the base image to 24.04 or adding the toolchain repository before this RUN,scripts/build-layer2.shfails before producingcpp-bench:latest.Useful? React with 👍 / 👎.