Skip to content

OCPBUGS-98152: [release-4.18] Handle missing sriov_numvfs during Mellanox firmware reset#1243

Open
SchSeba wants to merge 1 commit into
openshift:release-4.18from
SchSeba:cp-release-4.18-sriov-numvfs-20260702
Open

OCPBUGS-98152: [release-4.18] Handle missing sriov_numvfs during Mellanox firmware reset#1243
SchSeba wants to merge 1 commit into
openshift:release-4.18from
SchSeba:cp-release-4.18-sriov-numvfs-20260702

Conversation

@SchSeba

@SchSeba SchSeba commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • skip resetting sriov_numvfs to 0 when the sysfs file is not present after staging Mellanox firmware changes
  • avoid failing the Mellanox firmware reset flow while SRIOV_EN is still disabled until reboot

Test plan

  • Not run (backport only)

Made with Cursor

@SchSeba
Handle missing sriov_numvfs file in SetSriovNumVfs when resetting to 0
af2a3d9 
When SRIOV_EN is false the sriov_numvfs sysfs file does not exist.
SetSriovNumVfs now checks for the file before writing and returns
success when numVfs is 0 and the file is absent, so callers like
MlxResetFW do not need special error handling for this case.

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
(cherry picked from commit b93b9be)
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@openshift-ci openshift-ci Bot requested review from s1061123 and wizhaoredhat July 2, 2026 15:30
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2026
@SchSeba

SchSeba commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@SchSeba

SchSeba commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/retitle OCPBUGS-98152: [release-4.18] Handle missing sriov_numvfs during Mellanox firmware reset

@openshift-ci openshift-ci Bot changed the title [release-4.18] Handle missing sriov_numvfs during Mellanox firmware reset OCPBUGS-98152: [release-4.18] Handle missing sriov_numvfs during Mellanox firmware reset Jul 9, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: This pull request references Jira Issue OCPBUGS-98152, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
  • expected dependent Jira Issue OCPBUGS-98050 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

  • skip resetting sriov_numvfs to 0 when the sysfs file is not present after staging Mellanox firmware changes
  • avoid failing the Mellanox firmware reset flow while SRIOV_EN is still disabled until reboot

Test plan

  • Not run (backport only)

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jul 9, 2026
@SchSeba

SchSeba commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 9, 2026
@SchSeba

SchSeba commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/verified later @gregkopels

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Jul 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: This PR has been marked to be verified later by @gregkopels.

Details

In response to this:

/verified later @gregkopels

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@SchSeba

SchSeba commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: This pull request references Jira Issue OCPBUGS-98152, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19.z" instead
  • expected dependent Jira Issue OCPBUGS-98050 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-98050 to target a version in 4.19.0, 4.19.z, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@SchSeba

SchSeba commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: This pull request references Jira Issue OCPBUGS-98152, which is invalid:

  • expected dependent Jira Issue OCPBUGS-98050 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-98050 to target a version in 4.19.0, 4.19.z, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@SchSeba

SchSeba commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot

openshift-ci-robot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@SchSeba: This pull request references Jira Issue OCPBUGS-98152, which is invalid:

  • expected dependent Jira Issue OCPBUGS-98050 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zeeke

zeeke commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2026
@openshift-ci

openshift-ci Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SchSeba, zeeke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@s1061123 s1061123 Awaiting requested review from s1061123
@wizhaoredhat wizhaoredhat Awaiting requested review from wizhaoredhat

Assignees

@zeeke zeeke

@kononovn kononovn

@zhiqiangf zhiqiangf

@evgenLevin evgenLevin

@ajaggapa ajaggapa

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@SchSeba @openshift-ci-robot @zeeke @kononovn @zhiqiangf @evgenLevin @ajaggapa