OCPBUGS-23969,OCPBUGS-64886: Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into main#1230
Conversation
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
add validation webhooks for netfilter nic selector
When a SriovNetwork has a LASTNETWORKNAMESPACE annotation pointing to a namespace where the old NetworkAttachmentDefinition no longer exists, the reconciler returned a NotFound error and blocked creation of the new NAD. Handle NotFound errors gracefully by logging and continuing, so cleanup of non-existent resources does not prevent forward progress. Also fixes swapped Namespace/Name fields in the error log message. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
Bot
added
the
approved
Fix the rdma test, when the device plugin is restarted, the allocatable resource goes to 0 and then back to the original value that caused the test to fail. To not have a flaky test we don't use the consistency check, but an eventually check. Signed-off-by: Sebastian Sch <sebassch@gmail.com>
Fix NAD creation blocked by stale LASTNETWORKNAMESPACE annotation
SchSeba
force-pushed
the
merge-bot-master
branch
5 times, most recently
from
1975115 to
a726344
Compare
fix rdma test
A node can start with Drain_Required, which only triggers a partial drain for SR-IOV workloads. If the daemon later detects that the same change also requires a reboot, such as an RDMA subsystem mode change or firmware-related update, it could observe DrainComplete and proceed to reboot even though the node never went through a full drain. Fix this by resetting the desired drain state back to Idle whenever a reboot becomes required during or after a partial drain. This forces the operator to finish the rollback to Idle, after which the daemon re-requests Reboot_Required and gets a full drain before rebooting. Add daemon tests that cover the drain-to-reboot escalation flow and the main non-regression cases around partial and full drain handling. Signed-off-by: Sebastian Sch <sebassch@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
SchSeba
force-pushed
the
merge-bot-master
branch
7 times, most recently
from
7b8bf41 to
8e66677
Compare
|
/retitle OCPBUGS-64886: Merge https://github.com/k8snetworkplumbingwg/sriov-network-operator:master into main |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@SchSeba: This pull request references Jira Issue OCPBUGS-64886, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
SchSeba
force-pushed
the
merge-bot-master
branch
2 times, most recently
from
1da660d to
e9368fa
Compare
Signed-off-by: Sebastian Sch <sebassch@gmail.com>
|
/retest |
Conditions/network crds
|
/retest |
|
/lgtm |
|
@zeeke: Only users can be targets for the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
@zeeke: Only users can be targets for the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@SchSeba: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified later @zhiqiangf |
|
@SchSeba: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SchSeba, zeeke The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@SchSeba: Jira Issue OCPBUGS-23969: All pull requests linked via external trackers have merged: This pull request has the Jira Issue OCPBUGS-64886: All pull requests linked via external trackers have merged: This pull request has the DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
No description provided.