Update links and README.md#81601
Conversation
WalkthroughThis PR updates documentation for the ci-secret-bootstrap tool: the README now describes two configuration files (legacy ChangesDocumentation updates
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: psalajova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core-services/ci-secret-bootstrap/README.md`:
- Around line 5-11: The directory overview in README.md is misleading because it
lists only the secret-definition files while omitting gsm-project-config.yaml,
which is also used by ci-secret-bootstrap. Update the intro text to separate the
secret-definition/config files from the project config, and make sure the
inventory explicitly includes gsm-project-config.yaml alongside _config.yaml and
gsm-config.yaml so the README matches how the validation script uses these
files.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3622d79f-c2e4-4990-a6fa-cda695fcdee5
📒 Files selected for processing (2)
core-services/ci-secret-bootstrap/README.mdcore-services/ci-secret-bootstrap/gsm-config.yaml
|
@psalajova: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Similar to openshift/ci-docs#600, this PR contains the changes to the docs that will take effect once the secret migration is done.
/hold
Summary by CodeRabbit
Updated the CI secret bootstrap documentation to better explain how secret definitions are managed during the GSM migration. In practical terms, this clarifies for OpenShift CI contributors that the legacy Vault-based
_config.yamlis being phased out, whilegsm-config.yamlis now the source of truth for GSM-backed secret bundles and mappings. The README also now points contributors to the correct “Adding a New Secret to CI” guide, and the GSM config comment links directly to the relevant documentation instead of a placeholder.