OPCT-379: Fix PinnedImages test to respect node taints#30969
OPCT-379: Fix PinnedImages test to respect node taints#30969bshaw7 wants to merge 2 commits intoopenshift:release-4.21from
Conversation
Backport of OCPBUGS-78617 fix from main to release-4.21. The PinnedImages conformance test was selecting worker nodes without considering node taints, causing test failures in environments with dedicated/tainted nodes (like OPCT test infrastructure). Changes: - Added GetReadySchedulableWorkerNodes() utility function in test/extended/util/nodes.go to filter out nodes with NoSchedule/NoExecute taints and nodes with control-plane/master roles - Updated addWorkerNodesToCustomPool() in pinnedimages.go to use the new utility function - Tests now skip gracefully when insufficient schedulable worker nodes exist (handles SNO and compact cluster scenarios) This ensures the test works correctly across cluster topologies. Original PR: openshift#30913
openshift-ci-robot
added
the
jira/valid-reference
|
@bshaw7: This pull request references OPCT-379 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bshaw7: GitHub didn't allow me to request PR reviews from the following users: bshaw7. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bshaw7 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@bshaw7: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
We are observing the test is not impacting 4.21 on OCP configuration for platform external, let's hold this PR until ensuring we need or not this change. |
3 participants
Backport of OCPBUGS-78617 fix from main to release-4.21.
Problem
The PinnedImages conformance test was selecting worker nodes without considering node taints, causing test failures in environments with dedicated/tainted nodes (like OPCT test infrastructure).
Changes
GetReadySchedulableWorkerNodes()utility function intest/extended/util/nodes.goto filter out nodes with NoSchedule/NoExecute taints and nodes with control-plane/master rolesaddWorkerNodesToCustomPool()inpinnedimages.goto use the new utility functionThis ensures the test works correctly across cluster topologies, including SNO and compact clusters.
Original PR
#30913
Related
/cc @bshaw7