Skip to content

OCPBUGS-81737: Dynamically find worker-generated-kubelet MC name to support different platforms#30967

Open
BhargaviGudi wants to merge 1 commit intoopenshift:mainfrom
BhargaviGudi:OCPBUGS-81737
Open

OCPBUGS-81737: Dynamically find worker-generated-kubelet MC name to support different platforms#30967
BhargaviGudi wants to merge 1 commit intoopenshift:mainfrom
BhargaviGudi:OCPBUGS-81737

Conversation

@BhargaviGudi
Copy link
Copy Markdown
Contributor

@BhargaviGudi BhargaviGudi commented Apr 7, 2026

Bug: https://redhat.atlassian.net/browse/OCPBUGS-81737
Summary

  • Dynamically find worker-generated-kubelet MachineConfig name instead of hardcoding
  • Add getWorkerGeneratedKubeletMC helper function to node_utils.go
    Problem
    The test OCP-86395 was hardcoded to use 99-worker-generated-kubelet as the MachineConfig name. However, the prefix varies by platform/ocp version:
    Azure: 98-worker-generated-kubelet
    This caused the test to fail on Azure clusters with "MachineConfig not found" error.

Solution
Added a helper function getWorkerGeneratedKubeletMC that lists all MachineConfigs and finds the one containing worker-generated-kubelet in its name. This works across all platforms regardless of the numeric prefix.

Test:
[Jira:Node][sig-node] Node non-cnv swap configuration should reject user override of swap settings via KubeletConfig API [OCP-86395] [Lifecycle:informing] test passed on AWS and AZURE 4.22.0-0.nightly-2026-04-06-051707
periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade Passed

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@BhargaviGudi: This pull request references Jira Issue OCPBUGS-81737, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug: https://redhat.atlassian.net/browse/OCPBUGS-81737
Summary

  • Dynamically find worker-generated-kubelet MachineConfig name instead of hardcoding
  • Add getWorkerGeneratedKubeletMC helper function to node_utils.go
    Problem
    The test OCP-86395 was hardcoded to use 99-worker-generated-kubelet as the MachineConfig name. However, the prefix varies by platform/ocp version:
    Azure: 98-worker-generated-kubelet
    This caused the test to fail on Azure clusters with "MachineConfig not found" error.

Solution
Added a helper function getWorkerGeneratedKubeletMC that lists all MachineConfigs and finds the one containing worker-generated-kubelet in its name. This works across all platforms regardless of the numeric prefix.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0795e46c-9a7e-49c2-9ad5-50d65ec995cb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot requested review from bitoku and haircommander April 7, 2026 09:27
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BhargaviGudi
Once this PR has been reviewed and has the lgtm label, please assign cpmeadors for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 7, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@BhargaviGudi: This pull request references Jira Issue OCPBUGS-81737, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

@BhargaviGudi: This pull request references Jira Issue OCPBUGS-81737, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Bug: https://redhat.atlassian.net/browse/OCPBUGS-81737
Summary

  • Dynamically find worker-generated-kubelet MachineConfig name instead of hardcoding
  • Add getWorkerGeneratedKubeletMC helper function to node_utils.go
    Problem
    The test OCP-86395 was hardcoded to use 99-worker-generated-kubelet as the MachineConfig name. However, the prefix varies by platform/ocp version:
    Azure: 98-worker-generated-kubelet
    This caused the test to fail on Azure clusters with "MachineConfig not found" error.

Solution
Added a helper function getWorkerGeneratedKubeletMC that lists all MachineConfigs and finds the one containing worker-generated-kubelet in its name. This works across all platforms regardless of the numeric prefix.

Test:
[Jira:Node][sig-node] Node non-cnv swap configuration should reject user override of swap settings via KubeletConfig API [OCP-86395] [Lifecycle:informing] test passed on AWS 4.22.0-0.nightly-2026-04-06-051707

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

@BhargaviGudi: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dfa1bac0-3265-11f1-8e73-15c5620d4c01-0

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci-robot
Copy link
Copy Markdown

@BhargaviGudi: This pull request references Jira Issue OCPBUGS-81737, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Bug: https://redhat.atlassian.net/browse/OCPBUGS-81737
Summary

  • Dynamically find worker-generated-kubelet MachineConfig name instead of hardcoding
  • Add getWorkerGeneratedKubeletMC helper function to node_utils.go
    Problem
    The test OCP-86395 was hardcoded to use 99-worker-generated-kubelet as the MachineConfig name. However, the prefix varies by platform/ocp version:
    Azure: 98-worker-generated-kubelet
    This caused the test to fail on Azure clusters with "MachineConfig not found" error.

Solution
Added a helper function getWorkerGeneratedKubeletMC that lists all MachineConfigs and finds the one containing worker-generated-kubelet in its name. This works across all platforms regardless of the numeric prefix.

Test:
[Jira:Node][sig-node] Node non-cnv swap configuration should reject user override of swap settings via KubeletConfig API [OCP-86395] [Lifecycle:informing] test passed on AWS and AZURE 4.22.0-0.nightly-2026-04-06-051707

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-ovn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 7, 2026

@BhargaviGudi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn b44c843 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-serial-2of2 b44c843 link true /test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@BhargaviGudi BhargaviGudi changed the title WIP OCPBUGS-81737: Dynamically find worker-generated-kubelet MC name to support different platforms OCPBUGS-81737: Dynamically find worker-generated-kubelet MC name to support different platforms Apr 8, 2026
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2026
@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-ovn
/test e2e-aws-ovn-serial-2of2

@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

@cpmeadors and @ngopalak-redhat Could you please help to review this PR? Thanks

@BhargaviGudi
Copy link
Copy Markdown
Contributor Author

/verified by @BhargaviGudi

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 8, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@BhargaviGudi: This PR has been marked as verified by @BhargaviGudi.

Details

In response to this:

/verified by @BhargaviGudi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants