Skip to content

remove CUDN status condition tests broken by upstream changes#30957

Open
jluhrsen wants to merge 1 commit intoopenshift:mainfrom
jluhrsen:jluhrsen/remove-cudn-status-tests
Open

remove CUDN status condition tests broken by upstream changes#30957
jluhrsen wants to merge 1 commit intoopenshift:mainfrom
jluhrsen:jluhrsen/remove-cudn-status-tests

Conversation

@jluhrsen
Copy link
Copy Markdown
Contributor

@jluhrsen jluhrsen commented Apr 3, 2026

Summary

  • Upstream ovn-kubernetes commit added a new TransportAccepted status condition to all ClusterUserDefinedNetwork resources
  • Two tests use exact matchers on CUDN conditions and fail because they don't expect this new condition:
    • should delete managed NAD in namespaces that no longer apply to namespace-selector
    • when primary network exist, ClusterUserDefinedNetwork status should report not-ready
  • These tests are duplicates of upstream ovn-kubernetes e2e tests which have already been fixed. The upstream tests will run in openshift CI via the ovn-kubernetes-tests-ext binary once that framework is in production. Until then, the coverage gap is acceptable.
  • Alternative to NO-JIRA: fix CUDN status condition tests for new TransportAccepted condition #30958 which fixes the tests instead of removing them. We should merge one and close the other.

Test plan

  • Verify the two removed tests no longer appear in e2e runs
  • Verify no other tests are affected by the removal

🤖 Generated with Claude Code

@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 66415b77-560b-41a5-8d7a-202771b0ea9b

📥 Commits

Reviewing files that changed from the base of the PR and between ab911b1 and d185b5d.

📒 Files selected for processing (1)
  • test/extended/networking/network_segmentation.go
💤 Files with no reviewable changes (1)
  • test/extended/networking/network_segmentation.go

Walkthrough

Removed three ClusterUserDefinedNetwork e2e test cases from the network segmentation suite: (1) namespaceSelector.matchExpressions value mutation validating managed NAD deletions and CUDN active-namespace status update; (2) tenant-namespace primary NetworkAttachmentDefinition pre-exists causing CUDN to be not-ready with NetworkAttachmentDefinitionSyncError; (3) top-level scope primary NetworkAttachmentDefinition conflict asserting not-ready status and explicit NetworkAttachmentDefinitionSyncError messages.

Changes

Cohort / File(s) Summary
E2E Test Cases
test/extended/networking/network_segmentation.go
Deleted three ClusterUserDefinedNetwork test scenarios (total ~96 lines removed): (1) mutation of spec.namespaceSelector.matchExpressions[0].values and resulting NAD deletions/status update; (2) tenant-namespace primary NetworkAttachmentDefinition conflict causing CUDN not-ready with NetworkAttachmentDefinitionSyncError; (3) top-level scope primary NetworkAttachmentDefinition conflict asserting not-ready and explicit NetworkAttachmentDefinitionSyncError messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from kyrtapz and ricky-rav April 3, 2026 22:19
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
Once this PR has been reviewed and has the lgtm label, please assign tssurya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

upstream ovn-kubernetes commit [0] added a new TransportAccepted
status condition to ClusterUserDefinedNetwork resources. these two
tests use exact matchers on CUDN conditions and fail because they
don't expect the new condition.

these tests are duplicates of the upstream ovn-kubernetes e2e tests
which were fixed in that same commit. the upstream tests will run in
openshift CI via the ovn-kubernetes-tests-ext binary once that
framework is in production. until then, the coverage gap is
acceptable.

[0] ovn-kubernetes/ovn-kubernetes@b855462

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jluhrsen jluhrsen force-pushed the jluhrsen/remove-cudn-status-tests branch from ab911b1 to d185b5d Compare April 3, 2026 22:48
@jluhrsen
Copy link
Copy Markdown
Contributor Author

jluhrsen commented Apr 3, 2026

/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn openshift/ovn-kubernetes#3114

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/da0aa8f0-2faf-11f1-9cde-deedbbb81f7b-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants