remove CUDN status condition tests broken by upstream changes#30957
remove CUDN status condition tests broken by upstream changes#30957jluhrsen wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughRemoved three ClusterUserDefinedNetwork e2e test cases from the network segmentation suite: (1) namespaceSelector.matchExpressions value mutation validating managed NAD deletions and CUDN active-namespace status update; (2) tenant-namespace primary NetworkAttachmentDefinition pre-exists causing CUDN to be not-ready with NetworkAttachmentDefinitionSyncError; (3) top-level scope primary NetworkAttachmentDefinition conflict asserting not-ready status and explicit NetworkAttachmentDefinitionSyncError messages. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jluhrsen The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
12d10f5 to
ab911b1
Compare
upstream ovn-kubernetes commit [0] added a new TransportAccepted status condition to ClusterUserDefinedNetwork resources. these two tests use exact matchers on CUDN conditions and fail because they don't expect the new condition. these tests are duplicates of the upstream ovn-kubernetes e2e tests which were fixed in that same commit. the upstream tests will run in openshift CI via the ovn-kubernetes-tests-ext binary once that framework is in production. until then, the coverage gap is acceptable. [0] ovn-kubernetes/ovn-kubernetes@b855462 Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ab911b1 to
d185b5d
Compare
|
/payload-job-with-prs periodic-ci-openshift-release-main-ci-4.22-e2e-aws-ovn openshift/ovn-kubernetes#3114 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/da0aa8f0-2faf-11f1-9cde-deedbbb81f7b-0 |
Summary
TransportAcceptedstatus condition to all ClusterUserDefinedNetwork resourcesshould delete managed NAD in namespaces that no longer apply to namespace-selectorwhen primary network exist, ClusterUserDefinedNetwork status should report not-readyTest plan
🤖 Generated with Claude Code