Skip to content

OCPBUGS-81340: openshift-tests: allow duplicate pacemaker status collector CronJob events #30953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaypoulz wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −0
Open

OCPBUGS-81340: openshift-tests: allow duplicate pacemaker status collector CronJob events #30953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,20 @@ func NewUniversalPathologicalEventMatchers(kubeConfig *rest.Config, finalInterva
twoNodeEtcdEndpointsMatcher := newTwoNodeEtcdEndpointsConfigMissingEventMatcher(finalIntervals)
registry.AddPathologicalEventMatcherOrDie(twoNodeEtcdEndpointsMatcher)

// cluster-etcd-operator (TNF): the pacemaker status collector CronJob runs on a short schedule; the
// kube-controller-manager cronjob-controller emits SuccessfulCreate and SawCompletedJob on the CronJob
// InvolvedObject. Long openshift-tests runs can exceed the duplicate-event threshold.
// SuccessfulDelete churn is reduced by CEO Job TTL / history tuning (see OCPBUGS-81340).
registry.AddPathologicalEventMatcherOrDie(&SimplePathologicalEventMatcher{
name: "PacemakerStatusCollectorCronJobEvents",
locatorKeyRegexes: map[monitorapi.LocatorKey]*regexp.Regexp{
monitorapi.LocatorNamespaceKey: regexp.MustCompile(`^openshift-etcd-operator$`),
monitorapi.LocatorKey("cronjob"): regexp.MustCompile(`^pacemaker-status-collector$`),
},
messageReasonRegex: regexp.MustCompile(`^(SuccessfulCreate|SawCompletedJob)$`),
jira: "https://issues.redhat.com/browse/OCPBUGS-81340",
})

newConfigDriftMonitorStoppedTooOftenEventMatcher := newConfigDriftMonitorStoppedTooOftenEventMatcher(finalIntervals)
registry.AddPathologicalEventMatcherOrDie(newConfigDriftMonitorStoppedTooOftenEventMatcher)

Expand Down
12 changes: 12 additions & 0 deletions pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_events_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,18 @@ func TestAllowedRepeatedEvents(t *testing.T) {
Reason("MultipleVersions").Build(),
expectedAllowName: "OperatorMultipleVersions",
},
{
name: "pacemaker status collector cronjob successful create (KCM cronjob-controller)",
locator: monitorapi.Locator{
Keys: map[monitorapi.LocatorKey]string{
monitorapi.LocatorNamespaceKey: "openshift-etcd-operator",
monitorapi.LocatorKey("cronjob"): "pacemaker-status-collector",
},
},
msg: monitorapi.NewMessage().HumanMessage("Created job pacemaker-status-collector-29035215").
Reason("SuccessfulCreate").Build(),
expectedAllowName: "PacemakerStatusCollectorCronJobEvents",
},
}
for _, test := range tests {
registry := NewUpgradePathologicalEventMatchers(nil, nil)
Expand Down