CORENET-6168: Add ovn tests extension#30560
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@jluhrsen: This pull request references CORENET-4510 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.21.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-merge-robot
added
the
needs-rebase
jluhrsen
force-pushed
the
add-ovn-tests-extension
branch
from
21838fd to
2530736
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn openshift/ovn-kubernetes#2889 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2492bac0-cfed-11f0-8358-3266731cfe9a-0 |
openshift-merge-robot
added
the
needs-rebase
jluhrsen
force-pushed
the
add-ovn-tests-extension
branch
from
2530736 to
fb9c943
Compare
openshift-merge-robot
removed
the
needs-rebase
|
Scheduling required tests: |
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-aws-ovn-techpreview |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d0cdddf0-f712-11f0-8a43-5b8e3f27cf5c-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/246df2b0-f713-11f0-9ef8-c66ab29ab6a4-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade |
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-gcp-ovn-upgrade |
|
/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aks |
|
/payload-job periodic-ci-openshift-hypershift-release-4.21-periodics-e2e-aws-ovn |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/39259910-f713-11f0-8001-b3fa6dda7770-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-aws-upgrade-ovn-single-node |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3a746030-f713-11f0-92e0-2b2b6bce50cd-0 |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-upgrade-fips |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3b76b500-f713-11f0-94a2-893cd651492e-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.21-e2e-azure-ovn-upgrade |
this is a no-op commit just to help visually search for test extension binaries Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
jluhrsen
force-pushed
the
add-ovn-tests-extension
branch
from
46f0d77 to
c72aeb6
Compare
openshift-ci-robot
removed
the
verified
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pkg/test/extensions/binary.go`:
- Around line 293-295: The binaryPath value for the entry with imageTag
"cluster-version-operator" is missing the "-ext" suffix; update the map entry
where imageTag == "cluster-version-operator" (the struct literal containing
imageTag and binaryPath) to set binaryPath to
"/usr/bin/cluster-version-operator-tests-ext.gz" so it matches the naming
convention used by the other operator entries and prevents extraction failures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 76c79bac-5a85-493b-aacb-9c0e2bf83361
📒 Files selected for processing (1)
pkg/test/extensions/binary.go
| imageTag: "cluster-version-operator", | ||
| binaryPath: "/usr/bin/cluster-version-operator-tests.gz", | ||
| }, |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# First, read the file around the disputed lines to understand the context
cat -n pkg/test/extensions/binary.go | sed -n '280,310p'Repository: openshift/origin
Length of output: 1148
🏁 Script executed:
# Get the full extensionBinaries list to understand naming patterns
cat -n pkg/test/extensions/binary.go | sed -n '221,335p'Repository: openshift/origin
Length of output: 4171
🏁 Script executed:
# Search for references to cluster-version-operator binary paths in the codebase
rg "cluster-version-operator.*\.gz" -B 2 -A 2Repository: openshift/origin
Length of output: 321
🏁 Script executed:
# Search for any build or image definitions that might show what binaries are created
fd -e "Dockerfile" -e "Makefile" -e "*.sh" | head -20 | xargs -I {} grep -l "cluster-version-operator" {} 2>/dev/null || echo "No direct matches"Repository: openshift/origin
Length of output: 77
🏁 Script executed:
# Look for any references to "-tests.gz" vs "-tests-ext.gz" patterns
rg "\-tests.*\.gz|\-test.*\.gz" | head -30Repository: openshift/origin
Length of output: 3135
🏁 Script executed:
# Verify if there are any other references to cluster-version-operator in the codebase
# that might clarify what the actual binary filename should be
rg "cluster-version-operator" --type go -B 2 -A 2 | head -50Repository: openshift/origin
Length of output: 5302
🏁 Script executed:
# Check git history to see if this was recently changed
cd pkg/test/extensions && git log --oneline -20 -- binary.go 2>/dev/null || echo "Git log not available"Repository: openshift/origin
Length of output: 111
Fix missing -ext suffix in cluster-version-operator binary path
Line 294 has /usr/bin/cluster-version-operator-tests.gz, which deviates from the naming convention used consistently across all other ~30 entries in this list. Every other operator uses -tests-ext.gz (or -test-ext.gz). The correct path should be /usr/bin/cluster-version-operator-tests-ext.gz. If this file is not present in the payload image, extraction will fail and block the entire test run.
Proposed fix
{
imageTag: "cluster-version-operator",
- binaryPath: "/usr/bin/cluster-version-operator-tests.gz",
+ binaryPath: "/usr/bin/cluster-version-operator-tests-ext.gz",
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| imageTag: "cluster-version-operator", | |
| binaryPath: "/usr/bin/cluster-version-operator-tests.gz", | |
| }, | |
| imageTag: "cluster-version-operator", | |
| binaryPath: "/usr/bin/cluster-version-operator-tests-ext.gz", | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@pkg/test/extensions/binary.go` around lines 293 - 295, The binaryPath value
for the entry with imageTag "cluster-version-operator" is missing the "-ext"
suffix; update the map entry where imageTag == "cluster-version-operator" (the
struct literal containing imageTag and binaryPath) to set binaryPath to
"/usr/bin/cluster-version-operator-tests-ext.gz" so it matches the naming
convention used by the other operator entries and prevents extraction failures.
|
Scheduling required tests: |
|
/test e2e-aws-ovn-fips |
|
@jluhrsen: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: c72aeb6
|
|
/test e2e-aws-ovn-serial-2of2 |
|
Job Failure Risk Analysis for sha: c72aeb6
|
|
/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-bm openshift/ovn-kubernetes#3118 |
|
/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-bm openshift/ovn-kubernetes#3118 |
|
@jcaamano: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d8ab2420-31cc-11f1-95e1-e066ee5e05ce-0 |
|
/verified by openshift/ovn-kubernetes#3118 (comment) |
openshift-ci-robot
added
the
verified
|
@pperiyasamy: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/retest-required |
|
/approve based on the bm job results |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jluhrsen, neisw, pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Scheduling required tests: |
7 participants
No description provided.