Skip to content

[release-4.19] OCPBUGS-104468, OCPBUGS-101801: Upgraded brace expansion to 5.0.9 #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Parthivk100 wants to merge 1 commit into
base: release-4.19
Choose a base branch
from
Open

[release-4.19] OCPBUGS-104468, OCPBUGS-101801: Upgraded brace expansion to 5.0.9 #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
"mocha/js-yaml": "4.3.0",
"i18next-parser/js-yaml": "4.3.0",
"**/@istanbuljs/load-nyc-config/js-yaml": "3.15.0",
"brace-expansion": "5.0.7"
"brace-expansion": "5.0.9"

@ronlavi2412 ronlavi2412 Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From npm registry:

  • 5.0.7 (June 29, 2026): "node": "18 || 20 || >=22" ✅ Supports Node 18
  • 5.0.8 (July 23, 2026): "node": "20 || >=22" ❌ Dropped Node 18
  • 5.0.9 (July 30, 2026): "node": "20 || >=22" ❌ No Node 18

We may need to use version 2.1.4 or 3.0.6

@ronlavi2412 ronlavi2412 Aug 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like 2.1.4 is recommended:

Version 2.1.4 (RECOMMENDED):

  • ✅ CommonJS (module.exports) - backward compatible
  • ✅ Works with minimatch@3.x (which expects ^1.1.7) - same API
  • ✅ Works with minimatch@5.x (which expects ^2.0.1) - exact match
  • ✅ Fixes all 3 CVEs
  • ✅ Supports Node 18

Version 3.0.6 (RISKY):

  • ⚠️ ESM module (import/export, "type": "module")
  • ⚠️ minimatch@3.x and @5.x are both CommonJS - they might not be able to import ESM
  • ✅ Fixes all 3 CVEs
  • ✅ Supports Node 18

},
"dependencies": {
"@preact/signals-react": "^3.0.1",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2387,10 +2387,10 @@ boolbase@^1.0.0:
resolved "https://registry.yarnpkg.com/boolbase/-/boolbase-1.0.0.tgz#68dff5fbe60c51eb37725ea9e3ed310dcc1e776e"
integrity sha512-JZOSA7Mo9sNGB8+UjSgzdLtokWAky1zbztM3WRLCbZ70/3cTANmQmOdR7y2g+J0e2WXywy1yS468tY+IruqEww==

brace-expansion@5.0.7, brace-expansion@^1.1.7, brace-expansion@^2.0.1:
version "5.0.7"
resolved "https://registry.yarnpkg.com/brace-expansion/-/brace-expansion-5.0.7.tgz#1b0e46965b479dad65af737b4a02790a05498337"
integrity sha512-7oFy703dxfY3/NLxC1fh2SUCQ0H9rmAY+5EpDVfXjUTTs+HEwR2nYaqLv+GWcTsumwxPfiz6CzCNkwXwBUwqCA==
brace-expansion@5.0.9, brace-expansion@^1.1.7, brace-expansion@^2.0.1:
version "5.0.9"
resolved "https://registry.yarnpkg.com/brace-expansion/-/brace-expansion-5.0.9.tgz#7c72438809b5fa5babf54199a1f1c281a6984fcf"
integrity sha512-ScQ4IuvIEF1TMlP7Zt+vjJ//9zlPb2SDcxWxM3bk8s6t6GGdJ7KO1dCcTidOPJKePW30LE/2cT7wCyPho9/Wxg==
dependencies:
balanced-match "^4.0.2"

Expand Down