Skip to content

NO-JIRA: Added iperf3#189

Open
jforce wants to merge 2 commits into
openshift:mainfrom
jforce:main
Open

NO-JIRA: Added iperf3#189
jforce wants to merge 2 commits into
openshift:mainfrom
jforce:main

Conversation

@jforce

@jforce jforce commented Jul 16, 2026

Copy link
Copy Markdown

Adding the iperf3 to the image for testing/troubleshooting network performance

Summary by CodeRabbit

  • Chores
    • Added iperf3 to the container environment, enabling network performance testing tools in deployments.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Walkthrough

The Dockerfile’s base image package list now includes iperf3 in the packages installed through yum.

Changes

Base image packages

Layer / File(s) Summary
Add iperf3 package
Dockerfile
Adds iperf3 to the INSTALL_PKGS package list used by yum.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only Dockerfile changed; no Ginkgo tests or titles were added or modified, so the stable-name check is not applicable.
Test Structure And Quality ✅ Passed Not applicable: this PR only adds iperf3 in Dockerfile; no Ginkgo test code or test structure changed.
Microshift Test Compatibility ✅ Passed PR only adds iperf3 to Dockerfile; no Ginkgo/e2e tests or OpenShift API usage were added, so MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only Dockerfile changed; no new Ginkgo e2e tests or node-topology-sensitive code was added, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only the Dockerfile package list changed; no manifests, controllers, or scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed PR only updates Dockerfile to add iperf3; no process-level code or stdout writes were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only Dockerfile changed to add iperf3; no Ginkgo/e2e tests were added or modified, so this IPv6/disconnected-network check is not applicable.
No-Weak-Crypto ✅ Passed The PR only adds iperf3 to Dockerfile package installs; no weak ciphers, custom crypto, or secret comparisons are introduced.
Container-Privileges ✅ Passed Diff only adds iperf3 to Dockerfile’s package list; no privileged, hostPID/Network/IPC, capabilities, or securityContext settings were introduced.
No-Sensitive-Data-In-Logs ✅ Passed The PR only updates Dockerfile package installation to add iperf3; no logging code or sensitive-data output paths were changed.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: adding iperf3 to the image.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 16, 2026
@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Hi @jforce. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Dockerfile`:
- Line 21: Update the INSTALL_PKGS package list by moving iperf3 above iproute,
preserving the existing alphabetized ordering.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a139a912-2946-4b35-a62a-61f5190f4019

📥 Commits

Reviewing files that changed from the base of the PR and between 0b53ac3 and 99f620d.

📒 Files selected for processing (1)
  • Dockerfile

Comment thread Dockerfile
@qinqon

qinqon commented Jul 20, 2026

Copy link
Copy Markdown

At openshift virt we are quite interested on that to run our ovn-kubernetes e2e tests downstream using iperf3

@qinqon qinqon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tssurya tssurya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tssurya

tssurya commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

two high level questions - any security implications in adding this tool? + what's the approx image size increase? - i hope its negligible

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-ovn

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jforce, qinqon, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2026
@qinqon

qinqon commented Jul 20, 2026

Copy link
Copy Markdown

two high level questions - any security implications in adding this tool? + what's the approx image size increase? - i hope its negligible

Even I am not the autor I can add my "2 cents":

  • size: with deps is 0.5 mb
  • about security it's from RHEL past security advisors were fix there (CVE-2023-38403), also there is nothing that start iperf3 without admin knowing it, so security problem are super slow.

@qinqon

qinqon commented Jul 20, 2026

Copy link
Copy Markdown

@jforce @tssurya do we need to add it to the Dockerfile.fedora too ? not sure if the .fedora is part of origin or not.

@jforce

jforce commented Jul 20, 2026

Copy link
Copy Markdown
Author

+1 to @qinqon on the impact, IMHO extremely minimal

As for adding it to the Fedora Dockerfile I don't believe so, albeit this is my first contribution to this image, so unsure of any intricacies, but from my view just adding it to the core one was enough without looking into it.

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@jforce: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@qinqon

qinqon commented Jul 21, 2026

Copy link
Copy Markdown

I have run ovn-kubernetes upstream layer2 and localnet test OTE using this image instead of netshoot and they are passing allright.

@jforce jforce changed the title Added iperf3 NO-JIRA: Added iperf3 Jul 21, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 21, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@jforce: This pull request explicitly references no jira issue.

Details

In response to this:

Adding the iperf3 to the image for testing/troubleshooting network performance

Summary by CodeRabbit

  • Chores
  • Added iperf3 to the container environment, enabling network performance testing tools in deployments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants