OCPBUGS-74076: Fix: Enable boot diagnostics for Azure Stack Hub VMs

[gpei]

The deriveVirtualMachineParametersStackHub function was missing the DiagnosticsProfile field assignment, causing boot diagnostics to not be applied to Azure Stack Hub VMs even when correctly specified in the Machine configuration.

[openshift-ci-robot]

@gpei: This pull request references Jira Issue OCPBUGS-74076, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The deriveVirtualMachineParametersStackHub function was missing the DiagnosticsProfile field assignment, causing boot diagnostics to not be applied to Azure Stack Hub VMs even when correctly specified in the Machine configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gpei]

/jira refresh

[openshift-ci-robot]

@gpei: This pull request references Jira Issue OCPBUGS-74076, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gpei]

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 openshift/installer#10224

[openshift-ci]

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7aeec980-f9e2-11f0-8f5e-f212ccafe468-0

[openshift-ci]

@gpei: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[gpei]

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 openshift/installer#10224

[openshift-ci]

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5deb7650-fb16-11f0-89d1-164b85f8b486-0

[sunzhaohua2]

@gpei For storageAccountType: CustomerManaged, it work as expected.

          diagnostics:
            boot:
              customerManaged:
                storageAccountURI: https://imageregistryzhsuna9wjrk.blob.mtcazs.wwtatc.com/
              storageAccountType: CustomerManaged

# az vm show --name zhsun-ashfix-cjhqf-worker-mtcazs2-b8v6g -g zhsun-ashfix-cjhqf-rg --query 'diagnosticsProfile.bootDiagnostics'
{
 "enabled": true,
 "storageUri": "https://imageregistryzhsuna9wjrk.blob.mtcazs.wwtatc.com/"
}

For storageAccountType: AzureManaged machine creation failed with incorrect message, ASH does not support AzureManaged boot diagnostics storage. I created a bug https://issues.redhat.com/browse/OCPBUGS-74573

          diagnostics:
            boot:
              storageAccountType: AzureManaged

        RESPONSE 400: 400 Bad Request
        ERROR CODE: InvalidParameter
        --------------------------------------------------------------------------------
        {
          "error": {
            "code": "InvalidParameter",
            "message": "Required parameter 'bootDiagnostics.storageAccountUri' is missing (null).",
            "target": "bootDiagnostics.storageAccountUri"
          }
        }

[gpei]

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 openshift/installer#10224

[openshift-ci]

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ad7b9fc0-fb24-11f0-91b5-be2c7e67fc22-0

[gpei]

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28 openshift/installer#10224

[openshift-ci]

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0b6fd0a0-fb53-11f0-9560-fddbdd6f5af8-0

[damdo]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/hold

Until we decide what to do with: https://issues.redhat.com/browse/OCPBUGS-74573

[damdo]

^ cc. @gpei

[gpei]

@damdo Thanks for the review and reminding.
Regarding the validation of the diagnostics profile configuration, it should be added in https://github.com/openshift/machine-api-provider-azure/blob/main/pkg/cloud/azure/actuators/machine/reconciler.go#L912, right?
If so, I'd prefer to merge the current PR first, since it fixes the two supported boot-diagnostics strategies on ASH: UserManaged and Disabled. For the AzureManaged type, which is not supported for ASH, I think the validation can be added in a separate PR, specifically for OCPBUGS-74573.
I should have time to work on this during next week's Shift week. WDYT?