vsphere - Clear task ID cache on PatchMachine failure#1465
vsphere - Clear task ID cache on PatchMachine failure#1465jcpowermac wants to merge 3 commits intoopenshift:mainfrom
Conversation
When PatchMachine fails during Create, the stale task ID cache entry would permanently block the machine from progressing past the stale check on every future reconcile. Delete the cache entry on PatchMachine failure so the machine can recover. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-vsphere-ovn-techpreview-serial |
|
/test e2e-vsphere-ovn |
|
/test unit |
|
/test e2e-vsphere-ovn-techpreview-serial |
|
bad claude, this is really more broken |
This reverts commit 7bb4e90.
When PatchMachine fails during Create, the provider status (including the TaskRef) is lost. Without retry logic the stale TaskRef check permanently blocks the machine from progressing. Cache the failed provider status and retry the patch on the next reconcile when a stale TaskRef mismatch is detected. Clean up the cache in Update and Delete to prevent unbounded growth. Co-Authored-By: vr4manta <vr4manta@gmail.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/test e2e-vsphere-ovn-techpreview-serial |
|
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
When PatchMachine fails during Create, the stale task ID cache entry would permanently block the machine from progressing past the stale check on every future reconcile. Delete the cache entry on PatchMachine failure so the machine can recover.