OLS-3434 Add CI check for hermetic build hash file sync#2982
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Vimal Kumar <vimal78@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughA new Bash script, ChangesHermetic build dependency verification
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant Make as Makefile verify
participant Script as verify_hermetic_requirements.sh
participant UvLock as uv.lock
participant HashFiles as hermetic hash files
Make->>Script: run ./scripts/verify_hermetic_requirements.sh
Script->>UvLock: uv export runtime deps
Script->>HashFiles: parse package names from hash files
Script->>Script: normalize, exclude EXPECTED_MISSING, diff sets
alt missing packages found
Script-->>Make: exit failure with package report
else no missing packages
Script-->>Make: exit success ("OK")
end
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raptorsun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vimalk78: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@vimalk78 we may need to fix the error found in ci/prow/verify before merging |
Description
Summary
(requirements.hashes.source.txt / requirements.hashes.wheel.txt)
Context
OLS-3417 fixed a production crash caused by missing opentelemetry and Bedrock deps in the hermetic build. Two PRs had updated pyproject.toml and uv.lock but
forgot to update the hash files. This check would have caught both before merge.
Test plan
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit