Skip to content

Pin langchain community to 0.4.2#2976

Open
JoaoFula wants to merge 2 commits into
openshift:mainfrom
JoaoFula:pin-langchain-version
Open

Pin langchain community to 0.4.2#2976
JoaoFula wants to merge 2 commits into
openshift:mainfrom
JoaoFula:pin-langchain-version

Conversation

@JoaoFula

@JoaoFula JoaoFula commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Description

pinning langchain version to avoid ragas error in eval
Temporary workaround until there is a fix for vibrantlabsai/ragas#2741. Without fix, eval is broken.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Chores
    • Updated a third-party dependency version constraint to cap it within a tested, compatible release range.
    • Includes notes indicating the upper bound is temporary to address a compatibility concern and prevent unexpected behavior from newer versions.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b6071bf1-5d21-4e5b-8801-7d6da61eeb6a

📥 Commits

Reviewing files that changed from the base of the PR and between a771235 and 94028b0.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock, !uv.lock
📒 Files selected for processing (1)
  • pyproject.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

langchain-community in pyproject.toml is updated from >=0.3.81 to >=0.3.81,<0.4.2, with comments added next to the constraint.

Changes

Dependency constraint update

Layer / File(s) Summary
Upper bound for langchain-community
pyproject.toml
langchain-community now uses >=0.3.81,<0.4.2 with adjacent comments documenting the bound.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the dependency change, though it slightly overspecifies the version by implying a direct pin to 0.4.2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from bparees and xrajesh June 30, 2026 08:34
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tisnik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pyproject.toml`:
- Line 126: Add a preceding comment for the temporary langchain-community
version pin in the dependency list to explain that it is a workaround for the
ragas evaluation failure. Reference the relevant upstream issue/bug in the
comment, and state the exact condition for removing the pin once that bug is
fixed. Keep the comment adjacent to the pinned entry so future maintainers can
find it when reviewing the dependency declaration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7eae69b5-3122-40f6-8658-5fe5da6c7486

📥 Commits

Reviewing files that changed from the base of the PR and between 0458add and a771235.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock, !uv.lock
📒 Files selected for processing (1)
  • pyproject.toml

Comment thread pyproject.toml
@onmete

onmete commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@JoaoFula rebase?

@JoaoFula JoaoFula force-pushed the pin-langchain-version branch from 9887ef0 to 94028b0 Compare July 2, 2026 13:17
@JoaoFula

JoaoFula commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 2, 2026

Copy link
Copy Markdown

@JoaoFula: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 94028b0 link true /test images
ci/prow/e2e-ols-cluster 94028b0 link true /test e2e-ols-cluster

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants