Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion eval/system_azure_openai_lseval.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ core:
llm:
provider: "openai"
model: "gpt-5-mini"
temperature: 0.0
max_tokens: 512
timeout: 300
num_retries: 3
Expand Down
1 change: 0 additions & 1 deletion eval/system_openai_lseval.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ core:
llm:
provider: "openai"
model: "gpt-5-mini"
temperature: 1.0
max_tokens: 512
timeout: 300
num_retries: 3
Expand Down
1 change: 0 additions & 1 deletion eval/system_rhelai_vllm_lseval.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ core:
llm:
provider: "openai"
model: "gpt-5-mini"
temperature: 0.0
max_tokens: 512
timeout: 300
num_retries: 3
Expand Down
1 change: 0 additions & 1 deletion eval/system_rhoai_vllm_lseval.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ core:
llm:
provider: "openai"
model: "gpt-5-mini"
temperature: 0.0
max_tokens: 512
timeout: 300
num_retries: 3
Expand Down
1 change: 0 additions & 1 deletion eval/system_watsonx_lseval.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ core:
llm:
provider: "openai"
model: "gpt-5-mini"
temperature: 0.0
max_tokens: 512
timeout: 300
num_retries: 3
Expand Down
1 change: 0 additions & 1 deletion eval/troubleshooting/system.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ core:
llm:
provider: "openai"
model: "gpt-5-mini"
temperature: 0.0
max_tokens: 5000
timeout: 300
num_retries: 3
Expand Down
37 changes: 20 additions & 17 deletions tests/e2e/evaluation/test_lseval_periodic.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
import pytest
import yaml

MAX_EVAL_ERROR_RATE_PCT = 10.0

# LSEval periodic provider matrix (operator-backed backends under test)
_LSEVAL_PERIODIC_PROVIDERS = ("openai", "watsonx", "azure_openai")

Expand Down Expand Up @@ -189,17 +187,25 @@ def _run_lseval(eval_data: Path, out_dir: Path, system_config: Path) -> None:
summary_json = json.load(fh)
overall = summary_json["summary_stats"]["overall"]

if overall["error_rate"] > MAX_EVAL_ERROR_RATE_PCT:
judge_tokens = overall.get("total_judge_llm_tokens", -1)
judge_detail = (
"0 → OLS calls failed before judge was reached"
if judge_tokens == 0
else "judge was called"
)
print(
f"\n--- ERROR DIAGNOSTICS ---\n"
f"Judge LLM tokens used: {judge_tokens} ({judge_detail})\n"
)
error_rate = overall["error_rate"]
total = overall["TOTAL"]
errors = overall["ERROR"]
passed = total - errors

judge_tokens = overall.get("total_judge_llm_tokens", -1)
judge_detail = (
"0 → OLS calls failed before judge was reached"
if judge_tokens == 0
else "judge was called"
)
print(
f"\n--- EVAL SUMMARY ---\n"
f"Total={total} Passed={passed} Errors={errors} "
f"error_rate={error_rate:.1f}%\n"
f"Judge LLM tokens used: {judge_tokens} ({judge_detail})\n"
)

if errors:
with open(csv_files[0], encoding="utf-8") as fh:
reader = csv.DictReader(fh)
error_rows = [r for r in reader if r.get("result") == "ERROR"]
Expand All @@ -210,10 +216,7 @@ def _run_lseval(eval_data: Path, out_dir: Path, system_config: Path) -> None:
f" turn={row.get('turn_id','?')} reason={row.get('reason','?')[:200]}"
)

assert overall["error_rate"] <= MAX_EVAL_ERROR_RATE_PCT, (
f"{overall['ERROR']}/{overall['TOTAL']} evaluations errored "
f"(error_rate={overall['error_rate']:.1f}% > threshold {MAX_EVAL_ERROR_RATE_PCT}%)."
)
assert passed > 0, f"All {total} evaluations errored — zero successful results."


@pytest.mark.lseval
Expand Down