Skip to content

OLS-3087: Replace wildcard RBAC verb on namespace-scoped roles/rolebindings #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xrajesh wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −2
Open

OLS-3087: Replace wildcard RBAC verb on namespace-scoped roles/rolebindings #1788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92728de
OLS-3087: Replace wildcard RBAC verb on namespace-scoped roles/rolebi…
xrajesh Jul 3, 2026
9dcbe6b
OLS-3087: Add missing watch and patch verbs to namespace-scoped RBAC
xrajesh Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,4 +207,10 @@ rules:
- rolebindings
- roles
verbs:
- '*'
- create
- delete
- get
- list
- patch
- update
- watch
2 changes: 1 addition & 1 deletion internal/controller/olsconfig_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ type OLSConfigReconciler struct {
// Modify console CR to activate console plugin
// +kubebuilder:rbac:groups=operator.openshift.io,resources=consoles,verbs=watch;list;get;update
// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,resources=clusterroles;clusterrolebindings;rolebindings,verbs=get;list;create;update;patch;delete;watch
// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,namespace=openshift-lightspeed,resources=roles;rolebindings,verbs=*
// +kubebuilder:rbac:groups=rbac.authorization.k8s.io,namespace=openshift-lightspeed,resources=roles;rolebindings,verbs=get;list;watch;create;update;patch;delete
// NonResourceURLs for Lightspeed access control and metrics
// +kubebuilder:rbac:urls=/ls-access,verbs=get
// +kubebuilder:rbac:urls=/ols-metrics-access,verbs=get
Expand Down